-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL][L0] Use immediate commandlists. #5833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Rajiv Deodhar <[email protected]>
I took a brief look and looks great overall! The batching tests are, of course, expected to fail, and we need to:
Additionally, we need to
|
There is existing |
"There is existing _pi_context::ZeCommandListInit immediate command-list that we now use for buffer initialization. I think that can be changed to use the new infra instead." That commandlist uses ZE_COMMAND_QUEUE_MODE_SYNCHRONOUS for immediate initialization. Other commandlists do not use this mode so are not directly usable. |
True. Let's not touch it then. |
It just add this mode, but doesn't switch to it by default, right? Please update the description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This change adds a mode where the plugin uses immediate commandlists instead of standard commandlists. The default remains standard commandlists. The new mode is selected by setting an environment variable.
Signed-off-by: Rajiv Deodhar [email protected]