Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] test for barrier submission: https://github.com/intel/llvm/pul… #98

Merged
merged 4 commits into from
Feb 15, 2021
Merged

[SYCL] test for barrier submission: https://github.com/intel/llvm/pul… #98

merged 4 commits into from
Feb 15, 2021

Conversation

smaslov-intel
Copy link

Test for barrier submission in intel/llvm#3045

Signed-off-by: Sergey V Maslov [email protected]

@smaslov-intel smaslov-intel mentioned this pull request Jan 16, 2021
Merged
@vladimirlaz vladimirlaz requested a review from bso-intel January 19, 2021 08:35
bso-intel
bso-intel previously approved these changes Jan 19, 2021
View reviewed changes
Copy link

@bso-intel bso-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although this is a very corner case where no command is created before the barrier.

@vladimirlaz
Copy link

@smaslov-intel the test is passing without #3000 fix. Is it expected?

@smaslov-intel
Copy link
Author

smaslov-intel commented Jan 21, 2021 •
edited
Loading

@smaslov-intel the test is passing without #3000 fix. Is it expected?

Good catch. This was unexpected, and was caused by the fact host device was used.
I changed the test to use "default_selector". It should hang with the intel/llvm#3045 compiler fix.

bso-intel
bso-intel previously approved these changes Jan 22, 2021
View reviewed changes
Copy link

@bso-intel bso-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, it expectedly failed.
LGTM

@vladimirlaz
Copy link

The test will be submitted after retest with nightly containing product change.

@vladimirlaz
Copy link

vladimirlaz commented Jan 28, 2021 •
edited
Loading

@smaslov-intel, could you please fix failure on CUDA?

@vladimirlaz vladimirlaz requested a review from bso-intel January 28, 2021 09:00
vladimirlaz
vladimirlaz suggested changes Feb 3, 2021
View reviewed changes
Copy link

@vladimirlaz vladimirlaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smaslov-intel, could you please fix failure on CUDA?

@smaslov-intel
Copy link
Author

smaslov-intel commented Feb 5, 2021 •
edited
Loading

@smaslov-intel, could you please fix failure on CUDA?

@vladimirlaz : I cannot access the http://pre-commit.llvm.intel.com:8010/job/LLVM-Test-Suite-CI/job/LLVM-Test-Suite-CUDA/59/display/redirect (it says Network error). How do I restart the CUDA testing?

@smaslov-intel
add -fsycl-targets
5fd6303 
Signed-off-by: Sergey V Maslov <[email protected]>
@smaslov-intel
Copy link
Author

The CUDA failure is due to intel/llvm#3218.
I am disabling the new barrier test for CUDA in this PR.

@smaslov-intel
disable for CUDA
6c510c1 
Signed-off-by: Sergey V Maslov <[email protected]>
@vladimirlaz vladimirlaz merged commit f0587be into intel:intel Feb 15, 2021
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
@smaslov-intel
[SYCL] test for barrier submission: https://github.com/intel/llvm/pul… (
5074125 
intel/llvm-test-suite#98)

Signed-off-by: Sergey V Maslov <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vladimirlaz vladimirlaz vladimirlaz approved these changes

@bso-intel bso-intel Awaiting requested review from bso-intel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smaslov-intel @vladimirlaz @bso-intel