[SYCL] submit barrier command to execution (see issue #3000) #3045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bso-intel
reviewed
Jan 18, 2021
smaslov-intel
added a commit
to smaslov-intel/llvm-test-suite
that referenced
this pull request
Jan 21, 2021
Signed-off-by: Sergey V Maslov <[email protected]>
smaslov-intel
changed the title
|
TODO: Wait for #3081 to merge and re-base. |
smaslov-intel
force-pushed
the
barrier
branch
from
dca9cc3 to
7185491
Compare
smaslov-intel
changed the title
Signed-off-by: Sergey V Maslov <[email protected]>
smaslov-intel
force-pushed
the
barrier
branch
from
7185491 to
3f92696
Compare
acmnpv
pushed a commit
to gromacs/gromacs
that referenced
this pull request
Feb 18, 2021
Associated changes: - Added function stubs to PME: necessary for compilation. - Stricter SYCL hardware compatibility checks: limits on subgroup size and the availability of local memory. - The kernel implementation and overall logic closely follow the OpenCL implementation. Divergences are documented locally. Limitations: - No fine-grained timings yet. - Code-duplication with CUDA and OpenCL: see #2608. - Minor differences in local/nonlocal synchronization: see #3895, related to #2608. - Only the OpenCL backend was extensively tested. LevelZero works fine without MPI but stalls due to a known bug. The fix for DPCPP runtime is available, but not yet part of any OneAPI release: intel/llvm#3045. - The complex/position-restraints regression test fails: see #3846. - No performance tuning: see #3847. Performance on rnase-cubic system is similar to OpenCL implementation.
baixiaokuang
pushed a commit
to deepmodeling/GROMACS
that referenced
this pull request
Apr 8, 2021
Associated changes: - Added function stubs to PME: necessary for compilation. - Stricter SYCL hardware compatibility checks: limits on subgroup size and the availability of local memory. - The kernel implementation and overall logic closely follow the OpenCL implementation. Divergences are documented locally. Limitations: - No fine-grained timings yet. - Code-duplication with CUDA and OpenCL: see #2608. - Minor differences in local/nonlocal synchronization: see #3895, related to #2608. - Only the OpenCL backend was extensively tested. LevelZero works fine without MPI but stalls due to a known bug. The fix for DPCPP runtime is available, but not yet part of any OneAPI release: intel/llvm#3045. - The complex/position-restraints regression test fails: see #3846. - No performance tuning: see #3847. Performance on rnase-cubic system is similar to OpenCL implementation.
iclsrc
pushed a commit
that referenced
this pull request
Mar 28, 2025
llvm-spirv.cpp was relying on transitive includes for these. Also remove an unneeded `<set>` include. Original commit: KhronosGroup/SPIRV-LLVM-Translator@cedb8ae2e22102e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3000
A submission of the barrier was missing.
Test: intel/llvm-test-suite#98
Signed-off-by: Sergey V Maslov [email protected]