[SYCL] Fix DAE by avoiding creation of obsolete device images (#4977)

Due to an unintentional copy of the RTDeviceBinaryImage object that
was happening in ProgramManager::build(), the NativePrograms map
was getting populated by an extra entry. No duplicating entry was
being created in the m_EliminatedKernelArgMasks, which made the
image-based lookup in ProgramManager::getEliminatedKernelArgMask()
exit early. The returned empty KernelArgMask led to errors during
kernel argument setting whenever several native programs were created
(e.g. for `kernel_bundle` or device code split use cases).

Tested in intel/llvm-test-suite#575.

Signed-off-by: Artem Gindinson <[email protected]>
Co-authored-by: Maksim Sabianin <[email protected]>

Author: Artem Gindinson

sycl/include/CL/sycl/detail/device_binary_image.hpp

@@ -23,6 +23,14 @@ class RTDeviceBinaryImage : public pi::DeviceBinaryImage {
       : pi::DeviceBinaryImage(), ModuleHandle(ModuleHandle) {}
   RTDeviceBinaryImage(pi_device_binary Bin, OSModuleHandle ModuleHandle)
       : pi::DeviceBinaryImage(Bin), ModuleHandle(ModuleHandle) {}
+  // Explicitly delete copy constructor/operator= to avoid unintentional copies
+  RTDeviceBinaryImage(const RTDeviceBinaryImage &) = delete;
+  RTDeviceBinaryImage &operator=(const RTDeviceBinaryImage &) = delete;
+  // Explicitly retain move constructors to facilitate potential moves across
+  // collections
+  RTDeviceBinaryImage(RTDeviceBinaryImage &&) = default;
+  RTDeviceBinaryImage &operator=(RTDeviceBinaryImage &&) = default;
+
   OSModuleHandle getOSModuleHandle() const { return ModuleHandle; }
 
   ~RTDeviceBinaryImage() override {}

sycl/source/detail/program_manager/program_manager.cpp

@@ -1712,7 +1712,7 @@ device_image_plain ProgramManager::build(const device_image_plain &DeviceImage,
   SerializedObj SpecConsts = InputImpl->get_spec_const_blob_ref();
 
   // TODO: Unify this code with getBuiltPIProgram
-  auto BuildF = [this, &Context, Img, &Devs, &CompileOpts, &LinkOpts,
+  auto BuildF = [this, &Context, &Img, &Devs, &CompileOpts, &LinkOpts,
                  &InputImpl, SpecConsts] {
     applyOptionsFromImage(CompileOpts, LinkOpts, Img);
     ContextImplPtr ContextImpl = getSyclObjImpl(Context);