This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Enable DAE explicitly for several tests #575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until DAE is enabled by default in the compiler driver, make sure that it works properly with the specialization constant/kernel bundle APIs. Tests intel/llvm#4977. Signed-off-by: Artem Gindinson <[email protected]>
|
While the |
Signed-off-by: Artem Gindinson <[email protected]>
AGindinson
changed the title
AGindinson
pushed a commit
to AGindinson/llvm
that referenced
this pull request
Nov 22, 2021
Due to an unintentional copy of the RTDeviceBinaryImage object that was happening in ProgramManager::build(), the NativePrograms map was getting populated by an extra entry. No duplicating entry was being created in the m_EliminatedKernelArgMasks, which made the image-based lookup in ProgramManager::getEliminatedKernelArgMask() exit early. The returned empty KernelArgMask led to errors during kernel argument setting whenever several native programs were created (e.g. for `kernel_bundle` or device code split use cases). Tested in intel/llvm-test-suite#575. Signed-off-by: Artem Gindinson <[email protected]> Co-authored-by: Maksim Sabianin <[email protected]>
AGindinson
requested review from
AlexeySachkov,
Fznamznon and
kbobrovs
as code owners
|
/verify with intel/llvm#4977 |
AlexeySachkov
approved these changes
Nov 22, 2021
|
/verify with intel/llvm#4977 |
|
CUDA compilation failures for reduction tests in Jenkins/llvm-test-suite do not seem to be related to either of my patches. |
Fznamznon
reviewed
Nov 23, 2021
Fznamznon
approved these changes
Nov 23, 2021
|
@kbobrovs, could you please take a look? |
bader
pushed a commit
to intel/llvm
that referenced
this pull request
Nov 24, 2021
Due to an unintentional copy of the RTDeviceBinaryImage object that was happening in ProgramManager::build(), the NativePrograms map was getting populated by an extra entry. No duplicating entry was being created in the m_EliminatedKernelArgMasks, which made the image-based lookup in ProgramManager::getEliminatedKernelArgMask() exit early. The returned empty KernelArgMask led to errors during kernel argument setting whenever several native programs were created (e.g. for `kernel_bundle` or device code split use cases). Tested in intel/llvm-test-suite#575. Signed-off-by: Artem Gindinson <[email protected]> Co-authored-by: Maksim Sabianin <[email protected]>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…#575) Until DAE is enabled by default in the compiler driver, make sure that it works properly with the specialization constant/kernel bundle APIs. Extend onto device code split tests Tests intel#4977. Signed-off-by: Artem Gindinson <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until DAE is enabled by default in the compiler driver, make sure that
it works properly when multiple native programs are created (specialization
constants, device code split).
Tests intel/llvm#4977.
Signed-off-by: Artem Gindinson [email protected]