[SYCL] Fix DAE by avoiding creation of obsolete device images #4977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AGindinson
pushed a commit
to AGindinson/llvm-test-suite
that referenced
this pull request
Nov 19, 2021
Until DAE is enabled by default in the compiler driver, make sure that it works properly with the specialization constant/kernel bundle APIs. Tests intel/llvm#4977. Signed-off-by: Artem Gindinson <[email protected]>
AGindinson
force-pushed
the
dae-with-spec-consts
branch
from
1f62ecd to
41f38df
Compare
AGindinson
changed the title
|
Converted back to draft - I've found that a) the duplicate native program is still created, b) the copy vs by-pointer mechanism is not actually what I've described. Will investigate deeper why the change actually helps the DAE handling. |
Due to an unintentional copy of the RTDeviceBinaryImage object that was happening in ProgramManager::build(), the NativePrograms map was getting populated by an extra entry. No duplicating entry was being created in the m_EliminatedKernelArgMasks, which made the image-based lookup in ProgramManager::getEliminatedKernelArgMask() exit early. The returned empty KernelArgMask led to errors during kernel argument setting whenever several native programs were created (e.g. for `kernel_bundle` or device code split use cases). Tested in intel/llvm-test-suite#575. Signed-off-by: Artem Gindinson <[email protected]> Co-authored-by: Maksim Sabianin <[email protected]>
AGindinson
force-pushed
the
dae-with-spec-consts
branch
from
41f38df to
9f7d7e4
Compare
|
/verify with intel/llvm-test-suite#575 |
Signed-off-by: Artem Gindinson <[email protected]>
|
/verify with intel/llvm-test-suite#575 |
|
/verify with intel/llvm-test-suite#575 |
|
CUDA compilation failures for reduction tests in Jenkins/llvm-test-suite do not seem to be related to either of my patches. |
FYI - #5008. |
romanovvlad
approved these changes
Nov 23, 2021
vladimirlaz
pushed a commit
to intel/llvm-test-suite
that referenced
this pull request
Nov 25, 2021
Until DAE is enabled by default in the compiler driver, make sure that it works properly with the specialization constant/kernel bundle APIs. Extend onto device code split tests Tests intel/llvm#4977. Signed-off-by: Artem Gindinson <[email protected]>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…#575) Until DAE is enabled by default in the compiler driver, make sure that it works properly with the specialization constant/kernel bundle APIs. Extend onto device code split tests Tests intel#4977. Signed-off-by: Artem Gindinson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to an unintentional copy of the
RTDeviceBinaryImageobject thatwas happening in
ProgramManager::build(), theNativeProgramsmapwas getting populated by an extra entry. No duplicating entry was
being created in the
m_EliminatedKernelArgMasks, which made theimage-based lookup in
ProgramManager::getEliminatedKernelArgMask()exit early. The returned empty
KernelArgMaskled to errors duringkernel argument setting whenever several native programs were created
(e.g. for
kernel_bundleor device code split use cases).Tested in intel/llvm-test-suite#575.
Signed-off-by: Artem Gindinson [email protected]
Co-authored-by: Maksim Sabianin [email protected]