Skip to content

[SYCL][UR][CUDA] Fix some issues in cuda adapter's urDeviceGetInfo. #10248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2023
Merged

[SYCL][UR][CUDA] Fix some issues in cuda adapter's urDeviceGetInfo. #10248

merged 1 commit into from
Jul 18, 2023

Conversation

aarongreig
Copy link
Contributor

No description provided.

@aarongreig aarongreig requested a review from a team as a code owner July 6, 2023 15:46
@aarongreig aarongreig requested a review from jchlanda July 6, 2023 15:46
@aarongreig aarongreig temporarily deployed to aws July 6, 2023 16:18 — with GitHub Actions Inactive
@aarongreig aarongreig temporarily deployed to aws July 6, 2023 17:45 — with GitHub Actions Inactive
jchlanda
jchlanda approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@jchlanda jchlanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd change the commit message to something more descriptive, maybe Use correct types in CUDA's urDeviceGetInfo?

@aarongreig
[SYCL][UR][CUDA] Correct some types for a few GetDeviceInfo queries.
e3b16b5 
Also return the correct error code for unsupported enumerations.
@aarongreig aarongreig force-pushed the aaron/cudaAdapterDeviceInfoFixes branch from 55180ac to e3b16b5 Compare July 17, 2023 10:25
@aarongreig
Copy link
Contributor Author

Update the commit message, is there anyone else I should ping for more reviews/to get this merged @jchlanda?

@aarongreig aarongreig temporarily deployed to aws July 17, 2023 11:04 — with GitHub Actions Inactive
@aarongreig aarongreig temporarily deployed to aws July 17, 2023 12:43 — with GitHub Actions Inactive
@aarongreig
Copy link
Contributor Author

weird CI failure:

fatal: detected dubious ownership in repository at '/__w/repo_cache/intel/llvm'

@dm-vodopyanov
Copy link
Contributor

weird CI failure:

fatal: detected dubious ownership in repository at '/__w/repo_cache/intel/llvm'

Just in case we have an issue on that: #10324

@dm-vodopyanov dm-vodopyanov merged commit 18f23b0 into intel:sycl Jul 18, 2023
fabiomestre pushed a commit to fabiomestre/llvm that referenced this pull request Sep 26, 2023
@aarongreig
[SYCL][UR][CUDA] Fix some issues in cuda adapter's urDeviceGetInfo. (i…
15c5c16 
…ntel#10248)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@callumfare callumfare callumfare left review comments

@jchlanda jchlanda jchlanda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aarongreig @dm-vodopyanov @jchlanda @callumfare