Skip to content

[SYCL][libdevice] Use saturated __spirv builtin when convert fp16 to ull #10277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 20, 2023
Merged

[SYCL][libdevice] Use saturated __spirv builtin when convert fp16 to ull #10277

merged 6 commits into from
Jul 20, 2023

Conversation

jinge90
Copy link
Contributor

@jinge90 jinge90 commented Jul 10, 2023

No description provided.

@jinge90 jinge90 requested a review from a team as a code owner July 10, 2023 07:26
@jinge90 jinge90 requested a review from steffenlarsen July 10, 2023 07:26
@jinge90 jinge90 temporarily deployed to aws July 10, 2023 07:26 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to aws July 10, 2023 08:01 — with GitHub Actions Inactive
AGindinson
AGindinson reviewed Jul 13, 2023
View reviewed changes
Copy link
Contributor

@AGindinson AGindinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO similar adjustments would be needed to all __devicelib_imf_half2<int_type>_<mode> functions to guarantee that saturated conversions will take place (as long as it's expected from SYCL spec viewpoint)

@jinge90 jinge90 temporarily deployed to aws July 14, 2023 02:55 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to aws July 14, 2023 04:25 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to aws July 18, 2023 01:56 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to aws July 18, 2023 02:07 — with GitHub Actions Inactive
@jinge90 jinge90 requested a review from a team July 18, 2023 02:11
@jinge90
Copy link
Contributor Author

jinge90 commented Jul 18, 2023

Hi, @intel/llvm-gatekeepers
Could you help review and merge this patch?
Thanks very much.

@aelovikov-intel aelovikov-intel mentioned this pull request Jul 18, 2023
Merged
@aelovikov-intel
Copy link
Contributor

Hi @jinge90 , I've pushed a change to CI in #10444 to address its effect on this PR's pre-commit behavior. Can you please merge origin/sycl into you PR's branch? Results should be available by the morning time in Europe time zone once gatekeepers from there are online.

@jinge90 jinge90 temporarily deployed to aws July 19, 2023 01:13 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to aws July 19, 2023 02:48 — with GitHub Actions Inactive
@jinge90
Copy link
Contributor Author

jinge90 commented Jul 19, 2023

Hi @jinge90 , I've pushed a change to CI in #10444 to address its effect on this PR's pre-commit behavior. Can you please merge origin/sycl into you PR's branch? Results should be available by the morning time in Europe time zone once gatekeepers from there are online.

Hi, @aelovikov-intel
Already done, but 2 failures still happen and these 2 failures have nothing to do with this PR.
Thanks very much.

@aelovikov-intel
Copy link
Contributor

I'm not convinced

Timed Out Tests (1):
  SYCL :: Basic/stream/auto_flush.cpp

is unrelated. What is your reasoning?

@jinge90 jinge90 temporarily deployed to aws July 20, 2023 07:44 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to aws July 20, 2023 09:46 — with GitHub Actions Inactive
@jinge90
Copy link
Contributor Author

jinge90 commented Jul 20, 2023

Hi, @intel/llvm-gatekeepers
Pre-ci passed, could you help review and merge this patch?
Thanks very much.

@steffenlarsen steffenlarsen merged commit 99e8dbe into intel:sycl Jul 20, 2023
mdtoguchi pushed a commit to mdtoguchi/llvm that referenced this pull request Oct 18, 2023
@jinge90 @mdtoguchi
[SYCL][libdevice] Use saturated __spirv builtin when convert fp16 to …
0768c1c 
…ull (intel#10277)

Signed-off-by: jinge90 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AGindinson AGindinson AGindinson left review comments

@steffenlarsen steffenlarsen steffenlarsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jinge90 @aelovikov-intel @AGindinson @steffenlarsen