Skip to content

[SYCL][libdevice] Use saturated __spirv builtin when convert fp16 to ull #10277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 20, 2023
Merged

[SYCL][libdevice] Use saturated __spirv builtin when convert fp16 to ull #10277

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6f7642d
[SYCL][libdevice] Use saturated __spirv builtin when convering fp16 t…
jinge90 Jul 10, 2023
e41674b
Merge remote-tracking branch 'upstream/sycl' into fix_half2ull_sat
jinge90 Jul 14, 2023
8d5cd6c
use saturated spirv builtins for all half to integral type conversions
jinge90 Jul 14, 2023
3d3b0b3
Merge remote-tracking branch 'upstream/sycl' into fix_half2ull_sat
jinge90 Jul 18, 2023
d231ec2
Merge remote-tracking branch 'upstream/sycl' into fix_half2ull_sat
jinge90 Jul 19, 2023
0d1bb0d
Merge remote-tracking branch 'upstream/sycl' into fix_half2ull_sat
jinge90 Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 24 additions & 24 deletions libdevice/imf_utils/half_convert.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ _iml_half_internal __devicelib_imf_float2half_rz(float x) {
DEVICE_EXTERN_C_INLINE
int __devicelib_imf_half2int_rd(_iml_half_internal h) {
#if defined(__SPIR__)
return __spirv_ConvertFToS_Rint_rtn(h);
return __spirv_ConvertFToS_Rint_sat_rtn(h);
#else
return __iml_half2integral_s<int>(h, __IML_RTN);
#endif
Expand All @@ -64,7 +64,7 @@ int __devicelib_imf_half2int_rd(_iml_half_internal h) {
DEVICE_EXTERN_C_INLINE
int __devicelib_imf_half2int_rn(_iml_half_internal h) {
#if defined(__SPIR__)
return __spirv_ConvertFToS_Rint_rte(h);
return __spirv_ConvertFToS_Rint_sat_rte(h);
#else
return __iml_half2integral_s<int>(h, __IML_RTE);
#endif
Expand All @@ -73,7 +73,7 @@ int __devicelib_imf_half2int_rn(_iml_half_internal h) {
DEVICE_EXTERN_C_INLINE
int __devicelib_imf_half2int_ru(_iml_half_internal h) {
#if defined(__SPIR__)
return __spirv_ConvertFToS_Rint_rtp(h);
return __spirv_ConvertFToS_Rint_sat_rtp(h);
#else
return __iml_half2integral_s<int>(h, __IML_RTP);
#endif
Expand All @@ -82,7 +82,7 @@ int __devicelib_imf_half2int_ru(_iml_half_internal h) {
DEVICE_EXTERN_C_INLINE
int __devicelib_imf_half2int_rz(_iml_half_internal h) {
#if defined(__SPIR__)
return __spirv_ConvertFToS_Rint_rtz(h);
return __spirv_ConvertFToS_Rint_sat_rtz(h);
#else
return __iml_half2integral_s<int>(h, __IML_RTZ);
#endif
Expand All @@ -91,7 +91,7 @@ int __devicelib_imf_half2int_rz(_iml_half_internal h) {
DEVICE_EXTERN_C_INLINE
long long __devicelib_imf_half2ll_rd(_iml_half_internal h) {
#if defined(__SPIR__)
return __spirv_ConvertFToS_Rlong_rtn(h);
return __spirv_ConvertFToS_Rlong_sat_rtn(h);
#else
return __iml_half2integral_s<long long>(h, __IML_RTN);
#endif
Expand All @@ -100,7 +100,7 @@ long long __devicelib_imf_half2ll_rd(_iml_half_internal h) {
DEVICE_EXTERN_C_INLINE
long long __devicelib_imf_half2ll_rn(_iml_half_internal h) {
#if defined(__SPIR__)
return __spirv_ConvertFToS_Rlong_rte(h);
return __spirv_ConvertFToS_Rlong_sat_rte(h);
#else
return __iml_half2integral_s<long long>(h, __IML_RTE);
#endif
Expand All @@ -109,7 +109,7 @@ long long __devicelib_imf_half2ll_rn(_iml_half_internal h) {
DEVICE_EXTERN_C_INLINE
long long __devicelib_imf_half2ll_ru(_iml_half_internal h) {
#if defined(__SPIR__)
return __spirv_ConvertFToS_Rlong_rtp(h);
return __spirv_ConvertFToS_Rlong_sat_rtp(h);
#else
return __iml_half2integral_s<long long>(h, __IML_RTP);
#endif
Expand All @@ -118,7 +118,7 @@ long long __devicelib_imf_half2ll_ru(_iml_half_internal h) {
DEVICE_EXTERN_C_INLINE
long long __devicelib_imf_half2ll_rz(_iml_half_internal h) {
#if defined(__SPIR__)
return __spirv_ConvertFToS_Rlong_rtz(h);
return __spirv_ConvertFToS_Rlong_sat_rtz(h);
#else
return __iml_half2integral_s<long long>(h, __IML_RTZ);
#endif
Expand All @@ -127,7 +127,7 @@ long long __devicelib_imf_half2ll_rz(_iml_half_internal h) {
DEVICE_EXTERN_C_INLINE
short __devicelib_imf_half2short_rd(_iml_half_internal h) {
#if defined(__SPIR__)
return __spirv_ConvertFToS_Rshort_rtn(h);
return __spirv_ConvertFToS_Rshort_sat_rtn(h);
#else
return __iml_half2integral_s<short>(h, __IML_RTN);
#endif
Expand All @@ -136,7 +136,7 @@ short __devicelib_imf_half2short_rd(_iml_half_internal h) {
DEVICE_EXTERN_C_INLINE
short __devicelib_imf_half2short_rn(_iml_half_internal h) {
#if defined(__SPIR__)
return __spirv_ConvertFToS_Rshort_rte(h);
return __spirv_ConvertFToS_Rshort_sat_rte(h);
#else
return __iml_half2integral_s<short>(h, __IML_RTE);
#endif
Expand All @@ -145,7 +145,7 @@ short __devicelib_imf_half2short_rn(_iml_half_internal h) {
DEVICE_EXTERN_C_INLINE
short __devicelib_imf_half2short_ru(_iml_half_internal h) {
#if defined(__SPIR__)
return __spirv_ConvertFToS_Rshort_rtp(h);
return __spirv_ConvertFToS_Rshort_sat_rtp(h);
#else
return __iml_half2integral_s<short>(h, __IML_RTP);
#endif
Expand All @@ -154,7 +154,7 @@ short __devicelib_imf_half2short_ru(_iml_half_internal h) {
DEVICE_EXTERN_C_INLINE
short __devicelib_imf_half2short_rz(_iml_half_internal h) {
#if defined(__SPIR__)
return __spirv_ConvertFToS_Rshort_rtz(h);
return __spirv_ConvertFToS_Rshort_sat_rtz(h);
#else
return __iml_half2integral_s<short>(h, __IML_RTZ);
#endif
Expand All @@ -163,7 +163,7 @@ short __devicelib_imf_half2short_rz(_iml_half_internal h) {
DEVICE_EXTERN_C_INLINE
unsigned int __devicelib_imf_half2uint_rd(_iml_half_internal h) {
#if defined(__SPIR__)
return __spirv_ConvertFToU_Ruint_rtn(h);
return __spirv_ConvertFToU_Ruint_sat_rtn(h);
#else
return __iml_half2integral_u<unsigned int>(h, __IML_RTN);
#endif
Expand All @@ -172,7 +172,7 @@ unsigned int __devicelib_imf_half2uint_rd(_iml_half_internal h) {
DEVICE_EXTERN_C_INLINE
unsigned int __devicelib_imf_half2uint_rn(_iml_half_internal h) {
#if defined(__SPIR__)
return __spirv_ConvertFToU_Ruint_rte(h);
return __spirv_ConvertFToU_Ruint_sat_rte(h);
#else
return __iml_half2integral_u<unsigned int>(h, __IML_RTE);
#endif
Expand All @@ -181,7 +181,7 @@ unsigned int __devicelib_imf_half2uint_rn(_iml_half_internal h) {
DEVICE_EXTERN_C_INLINE
unsigned int __devicelib_imf_half2uint_ru(_iml_half_internal h) {
#if defined(__SPIR__)
return __spirv_ConvertFToU_Ruint_rtp(h);
return __spirv_ConvertFToU_Ruint_sat_rtp(h);
#else
return __iml_half2integral_u<unsigned int>(h, __IML_RTP);
#endif
Expand All @@ -190,7 +190,7 @@ unsigned int __devicelib_imf_half2uint_ru(_iml_half_internal h) {
DEVICE_EXTERN_C_INLINE
unsigned int __devicelib_imf_half2uint_rz(_iml_half_internal h) {
#if defined(__SPIR__)
return __spirv_ConvertFToU_Ruint_rtz(h);
return __spirv_ConvertFToU_Ruint_sat_rtz(h);
#else
return __iml_half2integral_u<unsigned int>(h, __IML_RTZ);
#endif
Expand All @@ -199,7 +199,7 @@ unsigned int __devicelib_imf_half2uint_rz(_iml_half_internal h) {
DEVICE_EXTERN_C_INLINE
unsigned long long __devicelib_imf_half2ull_rd(_iml_half_internal h) {
#if defined(__SPIR__)
return __spirv_ConvertFToU_Rulong_rtn(h);
return __spirv_ConvertFToU_Rulong_sat_rtn(h);
#else
return __iml_half2integral_u<unsigned long long>(h, __IML_RTN);
#endif
Expand All @@ -208,7 +208,7 @@ unsigned long long __devicelib_imf_half2ull_rd(_iml_half_internal h) {
DEVICE_EXTERN_C_INLINE
unsigned long long __devicelib_imf_half2ull_rn(_iml_half_internal h) {
#if defined(__SPIR__)
return __spirv_ConvertFToU_Rulong_rte(h);
return __spirv_ConvertFToU_Rulong_sat_rte(h);
#else
return __iml_half2integral_u<unsigned long long>(h, __IML_RTE);
#endif
Expand All @@ -217,7 +217,7 @@ unsigned long long __devicelib_imf_half2ull_rn(_iml_half_internal h) {
DEVICE_EXTERN_C_INLINE
unsigned long long __devicelib_imf_half2ull_ru(_iml_half_internal h) {
#if defined(__SPIR__)
return __spirv_ConvertFToU_Rulong_rtp(h);
return __spirv_ConvertFToU_Rulong_sat_rtp(h);
#else
return __iml_half2integral_u<unsigned long long>(h, __IML_RTP);
#endif
Expand All @@ -226,7 +226,7 @@ unsigned long long __devicelib_imf_half2ull_ru(_iml_half_internal h) {
DEVICE_EXTERN_C_INLINE
unsigned long long __devicelib_imf_half2ull_rz(_iml_half_internal h) {
#if defined(__SPIR__)
return __spirv_ConvertFToU_Rulong_rtz(h);
return __spirv_ConvertFToU_Rulong_sat_rtz(h);
#else
return __iml_half2integral_u<unsigned long long>(h, __IML_RTZ);
#endif
Expand All @@ -235,7 +235,7 @@ unsigned long long __devicelib_imf_half2ull_rz(_iml_half_internal h) {
DEVICE_EXTERN_C_INLINE
unsigned short __devicelib_imf_half2ushort_rd(_iml_half_internal h) {
#if defined(__SPIR__)
return __spirv_ConvertFToU_Rushort_rtn(h);
return __spirv_ConvertFToU_Rushort_sat_rtn(h);
#else
return __iml_half2integral_u<unsigned short>(h, __IML_RTN);
#endif
Expand All @@ -244,7 +244,7 @@ unsigned short __devicelib_imf_half2ushort_rd(_iml_half_internal h) {
DEVICE_EXTERN_C_INLINE
unsigned short __devicelib_imf_half2ushort_rn(_iml_half_internal h) {
#if defined(__SPIR__)
return __spirv_ConvertFToU_Rushort_rte(h);
return __spirv_ConvertFToU_Rushort_sat_rte(h);
#else
return __iml_half2integral_u<unsigned short>(h, __IML_RTE);
#endif
Expand All @@ -253,7 +253,7 @@ unsigned short __devicelib_imf_half2ushort_rn(_iml_half_internal h) {
DEVICE_EXTERN_C_INLINE
unsigned short __devicelib_imf_half2ushort_ru(_iml_half_internal h) {
#if defined(__SPIR__)
return __spirv_ConvertFToU_Rushort_rtp(h);
return __spirv_ConvertFToU_Rushort_sat_rtp(h);
#else
return __iml_half2integral_u<unsigned short>(h, __IML_RTP);
#endif
Expand All @@ -262,7 +262,7 @@ unsigned short __devicelib_imf_half2ushort_ru(_iml_half_internal h) {
DEVICE_EXTERN_C_INLINE
unsigned short __devicelib_imf_half2ushort_rz(_iml_half_internal h) {
#if defined(__SPIR__)
return __spirv_ConvertFToU_Rushort_rtz(h);
return __spirv_ConvertFToU_Rushort_sat_rtz(h);
#else
return __iml_half2integral_u<unsigned short>(h, __IML_RTZ);
#endif
Expand Down