Skip to content

[SYCL][NFC] Improve testing of ConvertToOpenCLType_t #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2020
Merged

[SYCL][NFC] Improve testing of ConvertToOpenCLType_t #1036

merged 1 commit into from
Jan 22, 2020

Conversation

AlexeySachkov
Copy link
Contributor

No description provided.

@AlexeySachkov AlexeySachkov mentioned this pull request Jan 22, 2020
Merged
offsake
offsake reviewed Jan 22, 2020
View reviewed changes
Copy link
Contributor

@offsake offsake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please remind me why this is for SYCL_DEVICE_ONLY?

@AlexeySachkov
Copy link
Contributor Author

Could you please remind me why this is for SYCL_DEVICE_ONLY?

vector_t is only available under __SYCL_DEVICE_ONLY__, according to the SYCL spec

@bader bader merged commit ed115ba into intel:sycl Jan 22, 2020
@AlexeySachkov AlexeySachkov deleted the private/asachkov/improve-convert-to-ocl-type-testing branch April 1, 2020 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offsake offsake offsake approved these changes

@rolandschulz rolandschulz Awaiting requested review from rolandschulz

Assignees

@offsake offsake

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexeySachkov @offsake @bader