[SYCL][FPGA] Add defaults for streaming and register_map fpga_kernel_properties, fix RegisterMap sycl-post-link #10406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenxue-intel
force-pushed
the
fpga_kernel_properties
branch
from
6d73d04 to
d7d9192
Compare
bowenxue-intel
changed the title
|
Ping @intel/llvm-reviewers-runtime |
bso-intel
approved these changes
Jul 21, 2023
|
Hi @intel/llvm-gatekeepers can this PR be merged? |
mdtoguchi
pushed a commit
to mdtoguchi/llvm
that referenced
this pull request
Oct 18, 2023
…properties, fix RegisterMap sycl-post-link (intel#10406) Add defaults for template parameters for streaming_interface and register_map_interface in fpga_kernel_properties.hpp since current usage gets too verbose, and defaults are allowed and implementation defined. Register map interface also does not match SPIRV expected interface [spec](https://github.com/KhronosGroup/SPIRV-Registry/blob/main/extensions/INTEL/SPV_INTEL_kernel_attributes.asciidoc) and [implementation](KhronosGroup/SPIRV-LLVM-Translator#1774), so update sycl-post-link.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add defaults for template parameters for streaming_interface and register_map_interface in fpga_kernel_properties.hpp since current usage gets too verbose, and defaults are allowed and implementation defined.
Register map interface also does not match SPIRV expected interface spec and implementation, so update sycl-post-link.