-
Notifications
You must be signed in to change notification settings - Fork 788
[CI] E2E task refactor #10459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] E2E task refactor #10459
Conversation
aelovikov-intel
commented
Jul 18, 2023
- Remove temporary experimental task sycl_linux_gen12_exp.yml
- Add possibility to trigger E2E testing on a nightly image manually So far it needs a branch inside intel/llvm but I plan on extending it to PRs later.
* Remove temporary experimental task sycl_linux_gen12_exp.yml * Add possibility to trigger E2E testing on a nightly image manually So far it needs a branch inside intel/llvm but I plan on extending it to PRs later.
cf2fee7
to
64f4b3b
Compare
type: choice | ||
options: | ||
- '-u 1001 --device=/dev/dri --privileged --cap-add SYS_ADMIN' | ||
- '-u 1001 --device=/dev/dri --device=/dev/kfd --privileged --cap-add SYS_ADMIN' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we want to add SYS_ADMIN
privs to the docker? Do we already do that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we already do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we want to add
SYS_ADMIN
privs to the docker?
This is still unanswered.
According to oneAPI documentation, this capability is needed for Intel Adviser/Inspector/Vtune tools (https://www.intel.com/content/www/us/en/docs/oneapi-base-toolkit/get-started-guide-linux/2023-2/using-containers-with-the-command-line.html).
AFAIK, our CI doesn't use these tools. Am I missing something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need it for the GPU reset on Intel GPU HW and I wanted to keep options close between these two options here. We might want to lessen those later but I'm focusing on the CI scripts at the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
I think we need it for the GPU reset on Intel GPU HW
Should we put this as a comment in the code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once we spend time to investigate and reduce the options we should document ones that will remain :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's give it a go!
* Remove temporary experimental task sycl_linux_gen12_exp.yml * Add possibility to trigger E2E testing on a nightly image manually So far it needs a branch inside intel/llvm but I plan on extending it to PRs later.