Skip to content

[CI] E2E task refactor #10459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2023
Merged

[CI] E2E task refactor #10459

merged 1 commit into from
Jul 20, 2023

Conversation

aelovikov-intel
Copy link
Contributor

  • Remove temporary experimental task sycl_linux_gen12_exp.yml
  • Add possibility to trigger E2E testing on a nightly image manually So far it needs a branch inside intel/llvm but I plan on extending it to PRs later.

@aelovikov-intel aelovikov-intel temporarily deployed to aws July 18, 2023 23:42 — with GitHub Actions Inactive
@aelovikov-intel aelovikov-intel temporarily deployed to aws July 19, 2023 00:20 — with GitHub Actions Inactive
* Remove temporary experimental task sycl_linux_gen12_exp.yml
* Add possibility to trigger E2E testing on a nightly image manually
  So far it needs a branch inside intel/llvm but I plan on extending it
  to PRs later.
@aelovikov-intel aelovikov-intel force-pushed the sycl-devops-pr/manual-e2e branch from cf2fee7 to 64f4b3b Compare July 19, 2023 14:48
@aelovikov-intel aelovikov-intel marked this pull request as ready for review July 19, 2023 15:19
@aelovikov-intel aelovikov-intel requested a review from a team as a code owner July 19, 2023 15:19
type: choice
options:
- '-u 1001 --device=/dev/dri --privileged --cap-add SYS_ADMIN'
- '-u 1001 --device=/dev/dri --device=/dev/kfd --privileged --cap-add SYS_ADMIN'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we want to add SYS_ADMIN privs to the docker? Do we already do that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we already do.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we want to add SYS_ADMIN privs to the docker?

This is still unanswered.
According to oneAPI documentation, this capability is needed for Intel Adviser/Inspector/Vtune tools (https://www.intel.com/content/www/us/en/docs/oneapi-base-toolkit/get-started-guide-linux/2023-2/using-containers-with-the-command-line.html).
AFAIK, our CI doesn't use these tools. Am I missing something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need it for the GPU reset on Intel GPU HW and I wanted to keep options close between these two options here. We might want to lessen those later but I'm focusing on the CI scripts at the moment.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

I think we need it for the GPU reset on Intel GPU HW

Should we put this as a comment in the code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we spend time to investigate and reduce the options we should document ones that will remain :)

Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a go!

@aelovikov-intel aelovikov-intel merged commit e7ce30b into sycl Jul 20, 2023
@aelovikov-intel aelovikov-intel deleted the sycl-devops-pr/manual-e2e branch July 20, 2023 14:42
@aelovikov-intel aelovikov-intel temporarily deployed to aws July 20, 2023 16:33 — with GitHub Actions Inactive
mdtoguchi pushed a commit to mdtoguchi/llvm that referenced this pull request Oct 18, 2023
* Remove temporary experimental task sycl_linux_gen12_exp.yml
* Add possibility to trigger E2E testing on a nightly image manually So
far it needs a branch inside intel/llvm but I plan on extending it to
PRs later.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants