Skip to content

[CI] E2E task refactor #10459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2023
Merged

[CI] E2E task refactor #10459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 39 additions & 2 deletions .github/workflows/linux_single_e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ on:
required: True
image_options:
type: string
required: False
required: True

target_devices:
type: string
Expand Down Expand Up @@ -59,6 +59,43 @@ on:
default: '{}'
required: False

workflow_dispatch:
inputs:
runner:
type: choice
options:
- '["Linux", "gen12"]'
- '["amdgpu"]'
image:
description: |
Use option ending with ":build" for AMDGPU, ":latest" for the rest.
type: choice
options:
- 'ghcr.io/intel/llvm/sycl_ubuntu2204_nightly:latest'
- 'ghcr.io/intel/llvm/sycl_ubuntu2204_nightly:build'
image_options:
description: |
Use option with "--device=/dev/kfd" for AMDGPU, without it for the rest.
type: choice
options:
- '-u 1001 --device=/dev/dri --privileged --cap-add SYS_ADMIN'
- '-u 1001 --device=/dev/dri --device=/dev/kfd --privileged --cap-add SYS_ADMIN'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we want to add SYS_ADMIN privs to the docker? Do we already do that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we already do.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we want to add SYS_ADMIN privs to the docker?

This is still unanswered.
According to oneAPI documentation, this capability is needed for Intel Adviser/Inspector/Vtune tools (https://www.intel.com/content/www/us/en/docs/oneapi-base-toolkit/get-started-guide-linux/2023-2/using-containers-with-the-command-line.html).
AFAIK, our CI doesn't use these tools. Am I missing something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need it for the GPU reset on Intel GPU HW and I wanted to keep options close between these two options here. We might want to lessen those later but I'm focusing on the CI scripts at the moment.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

I think we need it for the GPU reset on Intel GPU HW

Should we put this as a comment in the code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we spend time to investigate and reduce the options we should document ones that will remain :)

target_devices:
type: choice
options:
- 'opencl:cpu'
- 'opencl:gpu'
- 'opencl:acc'
- 'ext_oneapi_level_zero:gpu'
- 'ext_oneapi_hip:gpu'
- 'ext_intel_esimd_emulator:gpu'

env:
description: |
Suggested variables: LIT_FILTER, LIT_FILTER_OUT. LIT_OPTS won't work
as we redefine it as part of this workflow.
default: '{"LIT_FILTER":""}'

jobs:
lin_e2e_only:
name: ${{ inputs.name }}
Expand All @@ -83,7 +120,7 @@ jobs:
- uses: ./devops/actions/cached_checkout
with:
path: llvm
ref: ${{ inputs.ref }}
ref: ${{ inputs.ref || github.sha }}
merge_ref: ${{ inputs.merge_ref }}
cache_path: "/__w/repo_cache/"
- name: Install drivers
Expand Down
23 changes: 0 additions & 23 deletions .github/workflows/sycl_linux_gen12_exp.yml
View file
Open in desktop

This file was deleted.