Skip to content

[SYCL][Joint Matrix] Fix element_wise_all_ops test: use float for matrix C #10637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

YuriPlyakhin
Copy link
Contributor

@YuriPlyakhin YuriPlyakhin commented Aug 1, 2023

Float type should be used for matrix C and bfloat16 type should be used for matrix A.
Rewritten test like that and refactored to reduce code duplication.

@YuriPlyakhin YuriPlyakhin changed the title New attempt [SYCL][Joint Matrix] Fix element_wise_all_ops test: use float for matrix C Aug 1, 2023
@YuriPlyakhin YuriPlyakhin marked this pull request as ready for review August 1, 2023 19:57
Copy link
Contributor

@dkhaldi dkhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aelovikov-intel aelovikov-intel merged commit fd99ee7 into intel:sycl Aug 1, 2023
@YuriPlyakhin YuriPlyakhin deleted the el_wise_all_ops_fix_1 branch August 1, 2023 20:22
mdtoguchi pushed a commit to mdtoguchi/llvm that referenced this pull request Oct 18, 2023
…rix C (intel#10637)

Float type should be used for matrix C and bfloat16 type should be used
for matrix A.
Rewritten test like that and refactored to reduce code duplication.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants