Skip to content

Add fneg and fcmp transcoding tests #11186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

hvdijk
Copy link
Contributor

@hvdijk hvdijk commented Sep 14, 2023

Add skipped commit removing test not expected to pass.

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@a4a8f159

@hvdijk
Copy link
Contributor Author

hvdijk commented Sep 15, 2023

Note that this PR only changes tests, and the CI failure is a timeout in a test not modified by this PR; it cannot be related.

Copy link
Contributor

@AlexeySachkov AlexeySachkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I would like @MrSidims to double-check

@againull againull closed this Dec 20, 2023
@againull againull reopened this Dec 20, 2023
@againull againull changed the title Add skipped commit removing test not expected to pass. Add fneg and fcmp transcoding tests Dec 21, 2023
@againull againull merged commit 2c931ff into intel:sycl Dec 21, 2023
@hvdijk hvdijk deleted the llvm-spirv-missing-commit branch December 22, 2023 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants