[SYCL] Avoid copying of NormalizedKernelFunc temporary #11368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksandr-pavlyk
changed the title
Coverity analysis of IntelPython/dpctl.git SYCL-based projects shows 6721 hits of COPY_INSTEAD_OF_MOVE type issues in ResetHostKernelHelper with the suggestion to use std::move(NormalizedKernelFunc) instead. This PR applies that suggestion.
oleksandr-pavlyk
force-pushed
the
resolve-6721-copy-instead-of-move-in-handler-hpp
branch
from
0168e00 to
1b5361b
Compare
oleksandr-pavlyk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
oleksandr-pavlyk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@cperkinsintel Ping |
cperkinsintel
approved these changes
Oct 26, 2023
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
…tead-of-move-in-handler-hpp
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coverity analysis of IntelPython/dpctl.git SYCL-based projects shows 6721 hits of COPY_INSTEAD_OF_MOVE type issues in ResetHostKernelHelper with the suggestion to use std::move(NormalizedKernelFunc) instead.
This PR applies that suggestion.