[SYCL][XPTI] Add unique queue ID to trace #11548

KseniyaTikhomirova · 2023-10-16T10:53:41Z

No description provided.

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

sycl/source/detail/queue_impl.hpp

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

sycl/source/CMakeLists.txt

sycl/source/detail/queue_impl.hpp

sycl/source/detail/scheduler/commands.cpp

sycl/source/handler.cpp

sycl/unittests/xpti_trace/CMakeLists.txt

sycl/unittests/xpti_trace/xptitest_subscriber/XPTISubscriber.cpp

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

KseniyaTikhomirova · 2023-10-23T12:45:00Z

sycl-trace run example:

bash-5.1$ ./build/bin/sycl-trace --sycl --print-format=verbose ./a.out
[SYCL] Queue create:
queue_handle: 0x1b11a18
queue_id: 0
is_inorder: 1
sycl_device: 0x1c3fba8
sycl_device_name: Intel(R) Xeon(R) Platinum 8380 CPU @ 2.30GHz
sycl_context: 0x1a97728
[SYCL] Queue create:
queue_id: 1
is_inorder: 0
sycl_device: 0
sycl_device_name: SYCL host device
sycl_context: 0
[SYCL] Queue destroy:
queue_handle: 0x1b11a18
queue_id: 0
[SYCL] Queue destroy:
queue_id: 1

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

tovinkere

LGTM

tovinkere · 2023-10-25T16:05:46Z

sycl/source/detail/queue_impl.cpp

@@ -448,7 +453,7 @@ void *queue_impl::instrumentationProlog(const detail::code_location &CodeLoc,
      DevStr = "ACCELERATOR";
    else
      DevStr = "UNKNOWN";
-    xpti::addMetadata(WaitEvent, "sycl_device", DevStr);
+    xpti::addMetadata(WaitEvent, "sycl_device_type", DevStr);


Good catch!

tovinkere · 2023-10-25T16:08:42Z

sycl/source/detail/queue_impl.hpp

@@ -231,10 +192,18 @@ class queue_impl {
                  MDevice->is_host() ? 0 : MDevice->getHandleRef()));
        }
        xpti::addMetadata(TEvent, "is_inorder", MIsInorder);
+        xpti::addMetadata(TEvent, "queue_id", MQueueID);
+        if (!MHostQueue)
+          xpti::addMetadata(PrepareNotify.traceEvent(), "queue_handle",


Please replace "PrepareNotify.traceEvent()" with "TEvent" and avoid a function call

tovinkere · 2023-10-25T16:10:07Z

sycl/source/detail/queue_impl.hpp

+        xpti::addMetadata(TEvent, "is_inorder", MIsInorder);
+        xpti::addMetadata(TEvent, "queue_id", MQueueID);
+        if (!MHostQueue)
+          xpti::addMetadata(PrepareNotify.traceEvent(), "queue_handle",


Replace PrepareNotify.traceEvent() with TEvent

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

sergey-semenov · 2023-10-26T18:07:28Z

sycl/unittests/xpti_trace/QueueIDCheck.cpp

@@ -0,0 +1,189 @@
+//==------------ NodeCreation.cpp --- XPTI integration unit tests ----------==//


Suggested change

//==------------ NodeCreation.cpp --- XPTI integration unit tests ----------==//

//==------------ QueueIDCheck.cpp --- XPTI integration unit tests ----------==//

Not blocking

fixing here #11690

againull · 2023-10-26T19:49:36Z

@KseniyaTikhomirova Could you please fix post-commit failures after your commit: https://github.com/intel/llvm/actions/runs/6658855529/job/18096640484

againull · 2023-10-27T03:00:12Z

@KseniyaTikhomirova Could you please fix post-commit failures after your commit: https://github.com/intel/llvm/actions/runs/6658855529/job/18096640484

Fixed here #11682

KseniyaTikhomirova added 2 commits October 13, 2023 06:52

[SYCL] Add unique queue ID to xpti traces:queue_create and queue_destroy

0e65df8

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

add queue ID to task_begin traces

03381f8

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

KseniyaTikhomirova temporarily deployed to WindowsCILock October 16, 2023 10:54 — with GitHub Actions Inactive

KseniyaTikhomirova temporarily deployed to WindowsCILock October 16, 2023 11:16 — with GitHub Actions Inactive

KseniyaTikhomirova added 5 commits October 16, 2023 08:52

draft

d38e386

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

add test case

563a94f

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

add tests

e02636e

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

add trace to kernel shortcut + test

348431d

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

add handle to test

27ef055

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

KseniyaTikhomirova commented Oct 19, 2023

View reviewed changes

sycl/source/detail/queue_impl.hpp Outdated Show resolved Hide resolved

KseniyaTikhomirova commented Oct 19, 2023

View reviewed changes

sycl/source/detail/queue_impl.hpp Show resolved Hide resolved

add xptiReleaseEvent

1f8e0c2

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

KseniyaTikhomirova commented Oct 20, 2023

View reviewed changes

KseniyaTikhomirova added 3 commits October 23, 2023 03:21

fix some comments

719873d

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

fix format

25bdb2b

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

fix format in xpti sources

05b29d6

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

KseniyaTikhomirova temporarily deployed to WindowsCILock October 23, 2023 10:40 — with GitHub Actions Inactive

remove prints

30778b3

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

KseniyaTikhomirova temporarily deployed to WindowsCILock October 23, 2023 10:48 — with GitHub Actions Inactive

KseniyaTikhomirova temporarily deployed to WindowsCILock October 23, 2023 11:12 — with GitHub Actions Inactive

add queue_create/destroy to sycl-trace sycl print

b538afa

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

KseniyaTikhomirova temporarily deployed to WindowsCILock October 23, 2023 12:24 — with GitHub Actions Inactive

KseniyaTikhomirova temporarily deployed to WindowsCILock October 23, 2023 12:47 — with GitHub Actions Inactive

KseniyaTikhomirova added 2 commits October 23, 2023 08:03

add task_begin/end trace to sycl-trace tool

f78f389

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

fix subscribers and test

13ca4e2

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

KseniyaTikhomirova temporarily deployed to WindowsCILock October 23, 2023 15:47 — with GitHub Actions Inactive

KseniyaTikhomirova had a problem deploying to WindowsCILock October 23, 2023 16:32 — with GitHub Actions Failure

add E2E test

336acad

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

KseniyaTikhomirova temporarily deployed to WindowsCILock October 24, 2023 15:09 — with GitHub Actions Inactive

KseniyaTikhomirova added 3 commits October 24, 2023 08:46

add doc. part 1

b75e9cb

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

add doc. part 1 with fix

cc0a7b8

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

add doc. part 1 with fix 2

595e8b2

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

KseniyaTikhomirova temporarily deployed to WindowsCILock October 24, 2023 16:03 — with GitHub Actions Inactive

KseniyaTikhomirova temporarily deployed to WindowsCILock October 24, 2023 16:44 — with GitHub Actions Inactive

KseniyaTikhomirova added 2 commits October 25, 2023 04:52

add queue_id to node_create

dd05ab5

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

fix test

a49fbe2

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

KseniyaTikhomirova temporarily deployed to WindowsCILock October 25, 2023 11:57 — with GitHub Actions Inactive

KseniyaTikhomirova added 2 commits October 25, 2023 05:02

fix E2E test

a48d8be

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

add note

ae227b0

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

KseniyaTikhomirova temporarily deployed to WindowsCILock October 25, 2023 12:12 — with GitHub Actions Inactive

KseniyaTikhomirova marked this pull request as ready for review October 25, 2023 12:17

KseniyaTikhomirova requested a review from a team as a code owner October 25, 2023 12:17

KseniyaTikhomirova requested review from sergey-semenov and tovinkere and removed request for sergey-semenov October 25, 2023 12:17

KseniyaTikhomirova temporarily deployed to WindowsCILock October 25, 2023 12:35 — with GitHub Actions Inactive

add one more test and fix

4b43eb7

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

KseniyaTikhomirova temporarily deployed to WindowsCILock October 25, 2023 15:06 — with GitHub Actions Inactive

KseniyaTikhomirova temporarily deployed to WindowsCILock October 25, 2023 15:42 — with GitHub Actions Inactive

fix test

625a357

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

tovinkere approved these changes Oct 25, 2023

View reviewed changes

KseniyaTikhomirova temporarily deployed to WindowsCILock October 25, 2023 17:15 — with GitHub Actions Inactive

fix comments

8e7693c

Signed-off-by: Tikhomirova, Kseniya <[email protected]>

KseniyaTikhomirova temporarily deployed to WindowsCILock October 25, 2023 17:44 — with GitHub Actions Inactive

KseniyaTikhomirova temporarily deployed to WindowsCILock October 25, 2023 18:57 — with GitHub Actions Inactive

sergey-semenov approved these changes Oct 26, 2023

View reviewed changes

againull merged commit da4b83c into intel:sycl Oct 26, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SYCL][XPTI] Add unique queue ID to trace #11548

[SYCL][XPTI] Add unique queue ID to trace #11548

Uh oh!

KseniyaTikhomirova commented Oct 16, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

KseniyaTikhomirova commented Oct 23, 2023 •

edited

Loading

Uh oh!

tovinkere left a comment

Uh oh!

tovinkere Oct 25, 2023

Uh oh!

tovinkere Oct 25, 2023

Uh oh!

KseniyaTikhomirova Oct 25, 2023

Uh oh!

tovinkere Oct 25, 2023

Uh oh!

KseniyaTikhomirova Oct 25, 2023

Uh oh!

sergey-semenov Oct 26, 2023

Uh oh!

KseniyaTikhomirova Oct 27, 2023

Uh oh!

againull commented Oct 26, 2023

Uh oh!

againull commented Oct 27, 2023

Uh oh!

Uh oh!

		@@ -0,0 +1,189 @@
		//==------------ NodeCreation.cpp --- XPTI integration unit tests ----------==//

	//==------------ NodeCreation.cpp --- XPTI integration unit tests ----------==//
	//==------------ QueueIDCheck.cpp --- XPTI integration unit tests ----------==//

[SYCL][XPTI] Add unique queue ID to trace #11548

[SYCL][XPTI] Add unique queue ID to trace #11548

Uh oh!

Conversation

KseniyaTikhomirova commented Oct 16, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

KseniyaTikhomirova commented Oct 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tovinkere left a comment

Choose a reason for hiding this comment

Uh oh!

tovinkere Oct 25, 2023

Choose a reason for hiding this comment

Uh oh!

tovinkere Oct 25, 2023

Choose a reason for hiding this comment

Uh oh!

KseniyaTikhomirova Oct 25, 2023

Choose a reason for hiding this comment

Uh oh!

tovinkere Oct 25, 2023

Choose a reason for hiding this comment

Uh oh!

KseniyaTikhomirova Oct 25, 2023

Choose a reason for hiding this comment

Uh oh!

sergey-semenov Oct 26, 2023

Choose a reason for hiding this comment

Uh oh!

KseniyaTikhomirova Oct 27, 2023

Choose a reason for hiding this comment

Uh oh!

againull commented Oct 26, 2023

Uh oh!

againull commented Oct 27, 2023

Uh oh!

Uh oh!

KseniyaTikhomirova commented Oct 23, 2023 •

edited

Loading