[SYCL] Fix post-commit issues after PR#11548 #11682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sycl/source/handler.cpp
Outdated
| @@ -239,9 +239,11 @@ event handler::finalize() { | |||
| #ifdef XPTI_ENABLE_INSTRUMENTATION | |||
| // uint32_t StreamID, uint64_t InstanceID, xpti_td* TraceEvent, | |||
| int32_t StreamID = xptiRegisterStream(detail::SYCL_STREAM_NAME); | |||
| auto [CmdTraceEvent, InstanceID] = emitKernelInstrumentationData( | |||
| auto InstrumentationData = emitKernelInstrumentationData( | |||
There was a problem hiding this comment.
I'd rather keep the structured binding and re-write the lambda like this: https://godbolt.org/z/ofqcoaTGr
Comment on lines
55
to
56
| const void *, uint64_t InstanceID, | ||
| bool IsBegin) { |
There was a problem hiding this comment.
Suggested change
| const void *, uint64_t InstanceID, | |
| bool IsBegin) { | |
| [[maybe_unused]] const void *UserData, | |
| uint64_t InstanceID, bool IsBegin) { |
| @@ -76,7 +76,7 @@ void TraceTaskExecutionSignals(xpti::trace_event_data_t * /*Parent*/, | |||
|
|
|||
| void TraceQueueLifetimeSignals(xpti::trace_event_data_t * /*Parent*/, | |||
| xpti::trace_event_data_t *Event, | |||
| const void *UserData, bool IsCreation) { | |||
| const void *, bool IsCreation) { | |||
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
approved these changes
Oct 26, 2023
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@againull, @aelovikov-intel thank you for fixing this |
joeatodd
reviewed
Nov 1, 2023
Comment on lines
+247
to
+248
| auto EnqueueKernel = [&, CmdTraceEvent = CmdTraceEvent, | ||
| InstanceID = InstanceID]() { |
There was a problem hiding this comment.
This breaks compilation when XPTI_ENABLE_INSTRUMENTATION is not defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.