[SYCL][test-e2e] Fix how clang++ is called #11785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arvind Sudarsanam <[email protected]>
asudarsa
requested review from
maarquitos14 and
sarnex
and removed request for
maarquitos14
asudarsa
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
asudarsa
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Hi @sarnex Can you please take a quick look? Thanks |
|
@intel/llvm-gatekeepers . This test is ready to be merged. It has got approval from test author. Also, the test failure is obviously unrelated to this. Thanks |
steffenlarsen
approved these changes
Nov 17, 2023
wangdi4
pushed a commit
to wangdi4/llvm
that referenced
this pull request
Dec 12, 2023
Jira: https://jira.devtools.intel.com/browse/CMPLRLLVM-53056 xmain commit: [3b97561](intel-restricted/applications.compilers.llvm-project@3b97561) It was part of a pulldown. This test called clang++ directly. I think we need to use %clangxx Thanks Signed-off-by: Arvind Sudarsanam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test called clang++ directly. I think we need to use %clangxx
Thanks