[NFC][SYCL] Introduce get_ur_handles helper
#18168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aelovikov-intel
force-pushed
the
get-ur-handles
branch
from
eb1762f to
3130f77
Compare
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
To reduce the amount of boilerplate code necessary without it. As a nice side effect avoids creation of temporary `std::shared_ptr` where using references would have been enough.
aelovikov-intel
force-pushed
the
get-ur-handles
branch
from
3130f77 to
0f0fc96
Compare
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/bindless-images-reviewers can I get a review on this before the end of workday in your time zone? It should be relatively trivial. |
ProGTX
approved these changes
Apr 24, 2025
| @@ -341,5 +341,21 @@ void GetCapabilitiesIntersectionSet(const std::vector<sycl::device> &Devices, | |||
| } | |||
|
|
|||
| } // namespace detail | |||
|
|
|||
| // We're under sycl/source and these won't be exported but it's way more | |||
There was a problem hiding this comment.
these are awesome. I find myself reaching for getSyclObjImp, getAdapter and getHandlerRef on a nearly daily basis.
But how will other team members know to use them?
There was a problem hiding this comment.
I've updated all the places I found that can benefit from them. Hopefully copy-paste will spread the usage from here.
cperkinsintel
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reduce the amount of boilerplate code necessary without it. As a nice side effect avoids creation of temporary
std::shared_ptrwhere using references would have been enough.