[SYCL][Graph] Add new 'are_graphs_supported' helper function #11877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
martygrant
force-pushed
the
martin/addGraphSupportHelperFunction
branch
from
2fcef23 to
c2e9a93
Compare
martygrant
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
martygrant
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
EwanC
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
EwanC
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
EwanC
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
@reble @mfrancepillois could one (or both) of you review this on behalf of sycl-graph-reviewers. Although I'm happy now with this PR, I've pushed enough commits to it that my review wouldn't be objective. |
mfrancepillois
approved these changes
Nov 16, 2023
sycl/test-e2e/Graph/graph_exception_global_device_extension.cpp
Outdated
Show resolved
Hide resolved
…mine platform support for Graphs at runtime rather than the lit '// REQUIRES: <platform>' check at compile time. Fixed a bug in the usm_<variant> tests of trying to instantiate an int with a float value.
martygrant
force-pushed
the
martin/addGraphSupportHelperFunction
branch
from
1739f84 to
91e5446
Compare
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers this is ready to be merged |
sergey-semenov
pushed a commit
that referenced
this pull request
Nov 28, 2023
intel-llvm CI run for adding Command Buffers to the OpenCL Adapter in Unified Runtime - oneapi-src/unified-runtime#966 Also completes follow-on work identified in #11599 to add an OpenCL section to the SYCL-Graphs docs and update the e2e Graph tests. Updating the tests has since been completed in a separate PR - #11877 Depends on #11820 merging first. --------- Co-authored-by: Pablo Reble <[email protected]> Co-authored-by: Ewan Crawford <[email protected]> Co-authored-by: Kenneth Benzie (Benie) <[email protected]>
callumfare
pushed a commit
to kbenzie/intel-llvm
that referenced
this pull request
Dec 18, 2023
intel-llvm CI run for adding Command Buffers to the OpenCL Adapter in Unified Runtime - oneapi-src/unified-runtime#966 Also completes follow-on work identified in intel#11599 to add an OpenCL section to the SYCL-Graphs docs and update the e2e Graph tests. Updating the tests has since been completed in a separate PR - intel#11877 Depends on intel#11820 merging first. --------- Co-authored-by: Pablo Reble <[email protected]> Co-authored-by: Ewan Crawford <[email protected]> Co-authored-by: Kenneth Benzie (Benie) <[email protected]>
This was referenced Jan 8, 2024
kbenzie
pushed a commit
that referenced
this pull request
Jan 8, 2024
Add new 'are_graphs_supported' helper function to determine platform support for Graphs at runtime rather than the lit '// REQUIRES: <platform>' check at compile time. Fixed a bug in the usm_variant tests of trying to instantiate an int with a float value. This PR has been create in order to simplify the PR for adding OpenCL support to the SYCL Graph tests #11718. --------- Co-authored-by: Ewan Crawford <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new 'are_graphs_supported' helper function to determine platform support for Graphs
at runtime rather than the lit '// REQUIRES: ' check at compile time.
Fixed a bug in the usm_variant tests of trying to instantiate an int with a float value.
This PR has been create in order to simplify the PR for adding OpenCL support to the SYCL Graph tests #11718.