[SYCL][OpenCL] Enable graph extension on OpenCL backend #11718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwanC
reviewed
Oct 31, 2023
sycl/test-e2e/Graph/Explicit/assume_buffer_outlives_graph_property.cpp
Outdated
Show resolved
Hide resolved
sycl/test-e2e/Graph/graph_exception_global_device_extension.cpp
Outdated
Show resolved
Hide resolved
reble
reviewed
Oct 31, 2023
reble
reviewed
Oct 31, 2023
reble
reviewed
Oct 31, 2023
EwanC
reviewed
Nov 1, 2023
martygrant
force-pushed
the
martin/updateGraphE2ETests
branch
from
d6a4402 to
c6709f7
Compare
|
In a rebased force-push I have corrected the |
martygrant
force-pushed
the
martin/updateGraphE2ETests
branch
2 times, most recently
from
f3f47a1 to
7cd2323
Compare
|
Using this PR as the companion to the UR PR oneapi-src/unified-runtime#966 instead of the separate #11719 which I will now close. |
martygrant
force-pushed
the
martin/updateGraphE2ETests
branch
2 times, most recently
from
b320377 to
5345bbe
Compare
martygrant
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
martygrant
force-pushed
the
martin/updateGraphE2ETests
branch
from
5345bbe to
46c5e19
Compare
|
The Graph E2E tests added by this PR will also need updated as the other tests in this PR have been #11556 |
martygrant
force-pushed
the
martin/updateGraphE2ETests
branch
from
46c5e19 to
14d5934
Compare
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
EwanC
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
pushed a commit
that referenced
this pull request
Nov 17, 2023
Add new 'are_graphs_supported' helper function to determine platform support for Graphs at runtime rather than the lit '// REQUIRES: <platform>' check at compile time. Fixed a bug in the usm_variant tests of trying to instantiate an int with a float value. This PR has been create in order to simplify the PR for adding OpenCL support to the SYCL Graph tests #11718. --------- Co-authored-by: Ewan Crawford <[email protected]>
martygrant
force-pushed
the
martin/updateGraphE2ETests
branch
from
4ff6e64 to
8591790
Compare
reble
reviewed
Nov 27, 2023
reble
reviewed
Nov 27, 2023
reble
reviewed
Nov 27, 2023
reble
reviewed
Nov 27, 2023
…lper function to return early if Graphs are not supported by the device. Added OpenCL section to CommandGraph docs. Co-authored-by: Pablo Reble <[email protected]>
Describe user facing limitations of OpenCL graphs backend and document failing tests this directly affects.
Describe in exception message the name of the unsupported entry-point.
martygrant
force-pushed
the
martin/updateGraphE2ETests
branch
from
3d5e6b3 to
5d38699
Compare
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers please merge. |
|
@kbenzie This still needs approval from @intel/unified-runtime-reviewers |
kbenzie
approved these changes
Nov 28, 2023
how foolish of me! approved now. |
steffenlarsen
pushed a commit
that referenced
this pull request
Nov 28, 2023
Run CI for oneapi-src/unified-runtime#936 Depends on #11718 merging first. --------- Co-authored-by: Kenneth Benzie (Benie) <[email protected]>
17 tasks
callumfare
pushed a commit
to kbenzie/intel-llvm
that referenced
this pull request
Dec 18, 2023
intel-llvm CI run for adding Command Buffers to the OpenCL Adapter in Unified Runtime - oneapi-src/unified-runtime#966 Also completes follow-on work identified in intel#11599 to add an OpenCL section to the SYCL-Graphs docs and update the e2e Graph tests. Updating the tests has since been completed in a separate PR - intel#11877 Depends on intel#11820 merging first. --------- Co-authored-by: Pablo Reble <[email protected]> Co-authored-by: Ewan Crawford <[email protected]> Co-authored-by: Kenneth Benzie (Benie) <[email protected]>
callumfare
pushed a commit
to kbenzie/intel-llvm
that referenced
this pull request
Dec 18, 2023
Run CI for oneapi-src/unified-runtime#936 Depends on intel#11718 merging first. --------- Co-authored-by: Kenneth Benzie (Benie) <[email protected]>
This was referenced Jan 8, 2024
kbenzie
pushed a commit
that referenced
this pull request
Jan 8, 2024
Add new 'are_graphs_supported' helper function to determine platform support for Graphs at runtime rather than the lit '// REQUIRES: <platform>' check at compile time. Fixed a bug in the usm_variant tests of trying to instantiate an int with a float value. This PR has been create in order to simplify the PR for adding OpenCL support to the SYCL Graph tests #11718. --------- Co-authored-by: Ewan Crawford <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
intel-llvm CI run for adding Command Buffers to the OpenCL Adapter in Unified Runtime - oneapi-src/unified-runtime#966
Also completes follow-on work identified in #11599 to add an OpenCL section to the SYCL-Graphs docs and update the e2e Graph tests. Updating the tests has since been completed in a separate PR - #11877
Depends on #11820 merging first.