Skip to content

[SYCL][Graph] Enable specialization constants with graph #11556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Nov 9, 2023
Merged

[SYCL][Graph] Enable specialization constants with graph #11556

merged 14 commits into from
Nov 9, 2023

Conversation

EwanC
Copy link
Contributor

@EwanC EwanC commented Oct 17, 2023 •
edited
Loading

  • Enables specialization constants handling in SYCL-Graph extension.
  • Adds E2E tests that verify this behavior.
  • Removes unittests tests that checked for unsupported feature exception throwing.

@mfrancepillois @EwanC
[SYCL][Graph] Enable specification constants with graph
d95717a 
Enables specification constants handling in Graph.
Adds E2E tests that verify this behavior.
Removes unittests tests that checked for unsupported feature exception throwing.
@EwanC EwanC temporarily deployed to WindowsCILock October 17, 2023 08:12 — with GitHub Actions Inactive
@EwanC EwanC mentioned this pull request Oct 17, 2023
Closed
@EwanC EwanC temporarily deployed to WindowsCILock October 17, 2023 08:36 — with GitHub Actions Inactive
@EwanC EwanC marked this pull request as ready for review October 17, 2023 09:41
@EwanC EwanC requested review from a team as code owners October 17, 2023 09:41
@EwanC EwanC requested a review from sergey-semenov October 17, 2023 09:41
@bader
Copy link
Contributor

bader commented Oct 17, 2023

"specification constants" -> "specialization constants"

@EwanC EwanC changed the title [SYCL][Graph] Enable specification constants with graph [SYCL][Graph] Enable specialization constants with graph Oct 17, 2023
@EwanC
Copy link
Contributor Author

EwanC commented Oct 17, 2023 •
edited
Loading

"specification constants" -> "specialization constants"

Thanks for spotting 🤦 Updated PR title and description (since I think force pushing to change git commit message isn't the desired git workflow)

@EwanC EwanC temporarily deployed to WindowsCILock October 18, 2023 08:07 — with GitHub Actions Inactive
@EwanC EwanC temporarily deployed to WindowsCILock October 18, 2023 08:32 — with GitHub Actions Inactive
@EwanC EwanC temporarily deployed to WindowsCILock October 18, 2023 14:58 — with GitHub Actions Inactive
@EwanC EwanC temporarily deployed to WindowsCILock October 18, 2023 15:34 — with GitHub Actions Inactive
Bensuo
Bensuo approved these changes Oct 19, 2023
View reviewed changes
reble
reble reviewed Oct 19, 2023
View reviewed changes
@EwanC EwanC temporarily deployed to WindowsCILock October 20, 2023 07:41 — with GitHub Actions Inactive
@EwanC EwanC temporarily deployed to WindowsCILock October 20, 2023 08:07 — with GitHub Actions Inactive
@EwanC EwanC temporarily deployed to WindowsCILock October 23, 2023 08:17 — with GitHub Actions Inactive
@EwanC EwanC temporarily deployed to WindowsCILock October 23, 2023 08:43 — with GitHub Actions Inactive
@EwanC
Copy link
Contributor Author

EwanC commented Oct 23, 2023

@intel/llvm-reviewers-runtime Could this have a review please

@EwanC EwanC temporarily deployed to WindowsCILock October 27, 2023 08:26 — with GitHub Actions Inactive
@EwanC EwanC mentioned this pull request Oct 30, 2023
Closed
@EwanC
Copy link
Contributor Author

EwanC commented Nov 6, 2023

@intel/llvm-reviewers-runtime Can you review this please

steffenlarsen
steffenlarsen reviewed Nov 7, 2023
View reviewed changes
@EwanC EwanC requested a review from steffenlarsen November 9, 2023 09:12
steffenlarsen
steffenlarsen approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EwanC
Copy link
Contributor Author

EwanC commented Nov 9, 2023

@intel/llvm-gatekeepers I think this PR is good to merge, the CI is green and has approvals from necessary groups

@steffenlarsen steffenlarsen merged commit fca7f5e into intel:sycl Nov 9, 2023
@EwanC EwanC mentioned this pull request Nov 10, 2023
Merged
EwanC added a commit to reble/llvm that referenced this pull request Nov 10, 2023
@EwanC
[SYCL][Graph] Update spec supported features
b402905 
The following features defined in the specification
as unsupported, have working implementations upstream.

* intel#11418
* intel#11505
* intel#11556
@EwanC EwanC mentioned this pull request Nov 13, 2023
Closed
EwanC added a commit to reble/llvm that referenced this pull request Nov 15, 2023
@EwanC
[SYCL][Graph][Doc] Update spec supported features
ad5d07c 
The following features are defined in the specification as unsupported, but
have working implementations merged upstream. This PR updates the graphs
specification to reflect that and removes some trailing whitespace.

* intel#11418
* intel#11505
* intel#11556
* intel#11855
@EwanC EwanC mentioned this pull request Nov 15, 2023
Merged
steffenlarsen pushed a commit that referenced this pull request Nov 15, 2023
@EwanC
[SYCL][Graph][Doc] Update spec supported features (#11889)
156b730 
The following features are defined in the specification as unsupported,
but have working implementations merged upstream. This PR updates the
graphs specification to reflect that and removes some trailing
whitespace.

* #11418
* #11505
* #11556
* #11855
@EwanC EwanC mentioned this pull request Dec 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reble reble reble left review comments

@Bensuo Bensuo Bensuo approved these changes

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@sergey-semenov sergey-semenov Awaiting requested review from sergey-semenov sergey-semenov is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@EwanC @bader @reble @Bensuo @steffenlarsen @mfrancepillois