[SYCL][Graph] Add a shortcut for adding leaves as dependencies #11855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a node property that allows users to easily add all leaves of a graph as dependencies when creating a node with the explicit API. Updates the spec with this new feature. Adds unitests that check this behaviour.
mfrancepillois
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
mfrancepillois
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
mfrancepillois
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mfrancepillois
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
mfrancepillois
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
mfrancepillois
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
EwanC
reviewed
Nov 13, 2023
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
mfrancepillois
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mfrancepillois
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
EwanC
approved these changes
Nov 13, 2023
mfrancepillois
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
mfrancepillois
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
approved these changes
Nov 14, 2023
mfrancepillois
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mfrancepillois
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers could you please merge this PR |
EwanC
added a commit
to reble/llvm
that referenced
this pull request
Nov 15, 2023
The following features are defined in the specification as unsupported, but have working implementations merged upstream. This PR updates the graphs specification to reflect that and removes some trailing whitespace. * intel#11418 * intel#11505 * intel#11556 * intel#11855
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a node property that allows users to easily add all leaves of a graph as dependencies when creating a node with the explicit API.
Updates the spec with this new feature.
Adds unitests that check this behaviour.