[SYCL][Graph] Support for kernel-bundle #11505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mfrancepillois
commented
Oct 11, 2023
mfrancepillois
commented
- Adds support for using kernel-bundle in Graph.
- Adds tests checking that kernel bundles can be used with the Record&Replay API and the Explicit API.
Adds support for using kernel-bundle in Graph. Adds tests checking that kernel bundles can be used with the Record&Replay API and the Explcit API.
mfrancepillois
changed the title
mfrancepillois
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mfrancepillois
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| @@ -2388,8 +2388,31 @@ pi_int32 enqueueImpCommandBufferKernel( | |||
| pi_program PiProgram = nullptr; | |||
There was a problem hiding this comment.
@sergey-semenov , would you be able to look at the changes in this file? I'm not familiar enough to provide comprehensive review.
There was a problem hiding this comment.
The changes in this file look good to me.
There was a problem hiding this comment.
@aelovikov-intel @sergey-semenov Could one of you approve this PR if you are happy with the content, thanks.
mfrancepillois
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mfrancepillois
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
approved these changes
Oct 16, 2023
This was referenced Oct 30, 2023
EwanC
added a commit
to reble/llvm
that referenced
this pull request
Nov 10, 2023
The following features defined in the specification as unsupported, have working implementations upstream. * intel#11418 * intel#11505 * intel#11556
EwanC
added a commit
to reble/llvm
that referenced
this pull request
Nov 15, 2023
The following features are defined in the specification as unsupported, but have working implementations merged upstream. This PR updates the graphs specification to reflect that and removes some trailing whitespace. * intel#11418 * intel#11505 * intel#11556 * intel#11855
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.