Skip to content

[SYCL][Bindless] Add default constructor to bindless sampler #11895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 16, 2023
Merged

[SYCL][Bindless] Add default constructor to bindless sampler #11895

merged 5 commits into from
Nov 16, 2023

Conversation

Seanst98
Copy link
Contributor

  • Add default constructor to bindless sampler
  • Add by-value semantics to bindless sampler
  • Modify existing test to show this
  • Add these to the bindless spec

@Seanst98
[SYCL][Bindless] Add default ctor to bindless sampler
640d8e3 
 - Add default constructor to bindless sampler
 - Add by-value semantics to bindless sampler
 - Modify existing test to show this
 - Add these to the bindless spec
@Seanst98 Seanst98 requested a review from a team as a code owner November 15, 2023 15:52
@Seanst98
Copy link
Contributor Author

@intel/llvm-gatekeepers Can we merge this?

@againull againull merged commit d65f3aa into intel:sycl Nov 16, 2023
@Seanst98 Seanst98 deleted the sean/default-ctor-sampler branch November 16, 2023 16:27
@Seanst98 Seanst98 mentioned this pull request Nov 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaacault isaacault isaacault approved these changes

@przemektmalon przemektmalon przemektmalon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Seanst98 @isaacault @przemektmalon @againull