[Bindless][Exp] Add constructors to image handle structs #11896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
przemektmalon
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Seanst98
approved these changes
Nov 16, 2023
isaacault
approved these changes
Nov 16, 2023
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
przemektmalon
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
#11895 was merged. So this will have a conflict in the spec document. |
- Constructors were added to the `sampled_image_handle` and `unsampled_image_handle` structs to allow creation of image handles from raw handles - Removed `sampler_handle` member from `sampled_image_handle` struct, awaiting the LevelZero and SPIR-V extensions to become more mature before deciding whether we need a sampler handle - Align naming of raw image handle members between specification and implementation
przemektmalon
force-pushed
the
przemek/image-handle-constructor-from-raw
branch
from
5f89962 to
f2fcc77
Compare
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers can this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constructors were added to the
sampled_image_handleandunsampled_image_handlestructs to allow creation of image handles from raw handles.Removed
sampler_handlemember fromsampled_image_handlestruct, awaiting the LevelZero and SPIR-V extensions to become more mature before deciding whether we need a sampler handle.Align naming of raw image handle members between specification and implementation.