Fixed typos in the fpga_mem properties that are emited
#11968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemrad
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
artemrad
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
vmaksimo
approved these changes
Nov 22, 2023
bso-intel
approved these changes
Nov 22, 2023
|
@intel/llvm-gatekeepers |
wangdi4
pushed a commit
to wangdi4/llvm
that referenced
this pull request
Dec 12, 2023
intel#17838) (intel#17959) The property values now align with the [SPV_INTEL_fpga_memory_attributes](https://github.com/KhronosGroup/SPIRV-Registry/blob/main/extensions/INTEL/SPV_INTEL_fpga_memory_attributes.asciidoc) spec. (cherry picked from commit 7ca0d6f) Co-authored-by: Artem Radzikhovskyy <[email protected]> (cherry picked from commit 553be783f9ce8bb3efdeed425d57d2b4c73a007f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The property values now align with the SPV_INTEL_fpga_memory_attributes spec.