[SYCL][Driver] Add deprecated warning for backend GRF options on PVC #12029

sarnex · 2023-11-28T18:24:09Z

With the -ftarget-register-alloc-mode option, the user doesn't need to pass IGC flags to the compiler to set the GRF mode. On PVC, emit a warning in the most common case to suggest the user use the new option. This doesn't catch every case because the -device syntax is complicated, but it can help in the most common use case.

Signed-off-by: Sarnie, Nick <[email protected]>

sarnex · 2023-11-29T21:15:37Z

HIP and CUDA failures are both

Failed Tests (1):
  SYCL :: Regression/vec_rel_swizzle_ops.cpp

and are not related and are under investigation.

sarnex · 2023-11-29T21:19:05Z

clang/test/Driver/sycl-ftarget-register-alloc-mode-warning.cpp

+// RUN: %clang -fsycl -Xs "-device pvc -ze-intel-128-GRF-per-thread" -### %s 2>&1 | FileCheck -check-prefix=SMALL %s
+// RUN: %clang -fsycl -Xs "-ze-intel-enable-auto-large-GRF-mode -device pvc" -### %s 2>&1 | FileCheck -check-prefix=AUTO %s
+
+// RUN: %clang -fsycl -fsycl-targets=intel_gpu_pvc -Xs "-ze-opt-large-register-file" -### %s 2>&1 | FileCheck -check-prefix=LARGE %s


Did I miss any important cases here?

So do we care about potential usages like -Xs -ze-opt-large-register-file -Xs "-device pvc"?

im gonna go with no because i've never seen anybody do that and it seems like it would be pretty annoying to deal with

sarnex · 2023-11-29T21:20:41Z

clang/lib/Driver/ToolChains/SYCL.cpp

+  // Make sure to only warn for once for gen targets as the translate
+  // options tree is called twice but only the second time has the
+  // device set.
+  if (Triple.isSPIR() && Triple.getSubArch() == llvm::Triple::SPIRSubArch_gen &&


This is kinda gross but we end up calling the entire translate backend opt tree super early in selectBfloatLibs so if we don't do anything the warning is thrown twice for the same backend opt instance.

this would probably need some kind of cleanup so we can do BE arg checking from anywhere and not be impacted by multiple diagnostic outputs, but yeah, it's not pretty.

mdtoguchi · 2023-11-29T21:39:02Z

clang/test/Driver/sycl-ftarget-register-alloc-mode-warning.cpp

+
+int main() {
+}


Actual source code not needed - everything is -### checked.

nice catch, thanks

mdtoguchi · 2023-11-29T21:44:27Z

clang/test/Driver/sycl-ftarget-register-alloc-mode-warning.cpp

+// RUN: %clang -fsycl -Xs "-device pvc -ze-intel-128-GRF-per-thread" -### %s 2>&1 | FileCheck -check-prefix=SMALL %s
+// RUN: %clang -fsycl -Xs "-ze-intel-enable-auto-large-GRF-mode -device pvc" -### %s 2>&1 | FileCheck -check-prefix=AUTO %s
+
+// RUN: %clang -fsycl -fsycl-targets=intel_gpu_pvc -Xs "-ze-opt-large-register-file" -### %s 2>&1 | FileCheck -check-prefix=LARGE %s


So do we care about potential usages like -Xs -ze-opt-large-register-file -Xs "-device pvc"?

mdtoguchi · 2023-11-29T21:45:33Z

clang/lib/Driver/ToolChains/SYCL.cpp

+  // Make sure to only warn for once for gen targets as the translate
+  // options tree is called twice but only the second time has the
+  // device set.
+  if (Triple.isSPIR() && Triple.getSubArch() == llvm::Triple::SPIRSubArch_gen &&


this would probably need some kind of cleanup so we can do BE arg checking from anywhere and not be impacted by multiple diagnostic outputs, but yeah, it's not pretty.

Signed-off-by: Sarnie, Nick <[email protected]>

sarnex · 2023-12-01T14:42:41Z

@intel/dpcpp-cfe-reviewers Hey all, mind reviewing this one? Just added a warning in the td file.

premanandrao · 2023-12-01T15:20:37Z

clang/include/clang/Basic/DiagnosticDriverKinds.td

@@ -399,6 +399,9 @@ def err_drv_fsycl_wrong_optimization_options : Error<
 def warn_drv_fsycl_add_default_spec_consts_image_flag_in_non_AOT : Warning<
  "-fsycl-add-default-spec-consts-image flag has an effect only in Ahead of Time Compilation mode (AOT).">,
  InGroup<SyclTarget>;
+def warn_drv_ftarget_register_alloc_mode_pvc : Warning<
+  "using %0 to set GRF mode on PVC hardware is deprecated; use -ftarget-register-alloc-mode=pvc:%1">,


Suggested change

"using %0 to set GRF mode on PVC hardware is deprecated; use -ftarget-register-alloc-mode=pvc:%1">,

"using '%0' to set GRF mode on PVC hardware is deprecated; use '-ftarget-register-alloc-mode=pvc:%1'">,

fixed in latest commit, thank you!

Signed-off-by: Sarnie, Nick <[email protected]>

sarnex · 2023-12-01T16:43:37Z

@intel/dpcpp-devops-reviewers Cuda CI not looking too hot:

  Error response from daemon: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: error running hook #0: error running hook: exit status 1, stdout: , stderr: Auto-detected mode as 'legacy'
  nvidia-container-cli: requirement error: unsatisfied condition: cuda>=12.1, please update your driver to a newer version, or use an earlier cuda container: unknown

sarnex · 2023-12-01T16:51:09Z

@intel/llvm-gatekeepers Can we merge this one? Cuda CI is failing but it passed in an earlier commit here and all I did since then is reword a warning which is tested in LIT and passes on other platforms.

sarnex force-pushed the warn branch from 7618938 to b0b0502 Compare November 28, 2023 20:43

sarnex had a problem deploying to WindowsCILock November 28, 2023 23:05 — with GitHub Actions Failure

sarnex force-pushed the warn branch from b0b0502 to e389838 Compare November 29, 2023 16:11

sarnex temporarily deployed to WindowsCILock November 29, 2023 16:13 — with GitHub Actions Inactive

sarnex had a problem deploying to WindowsCILock November 29, 2023 16:53 — with GitHub Actions Failure

sarnex mentioned this pull request Nov 29, 2023

[SYCL] Fix operators for bool swizzled vec #12001

Merged

[SYCL][Driver] Add deprecated warning for backend GRF options on PVC

a5b9edd

Signed-off-by: Sarnie, Nick <[email protected]>

sarnex force-pushed the warn branch from e389838 to a5b9edd Compare November 29, 2023 18:40

sarnex temporarily deployed to WindowsCILock November 29, 2023 18:49 — with GitHub Actions Inactive

sarnex temporarily deployed to WindowsCILock November 29, 2023 19:25 — with GitHub Actions Inactive

sarnex commented Nov 29, 2023

View reviewed changes

sarnex marked this pull request as ready for review November 29, 2023 21:21

sarnex requested review from a team as code owners November 29, 2023 21:21

mdtoguchi reviewed Nov 29, 2023

View reviewed changes

address feedback

999fa12

Signed-off-by: Sarnie, Nick <[email protected]>

sarnex temporarily deployed to WindowsCILock November 29, 2023 21:53 — with GitHub Actions Inactive

mdtoguchi approved these changes Nov 29, 2023

View reviewed changes

aelovikov-intel mentioned this pull request Nov 29, 2023

[SYCL] Forbid non-trivially-copyable type in annotated_ptr/ref class #11798

Merged

sarnex had a problem deploying to WindowsCILock November 29, 2023 22:23 — with GitHub Actions Failure

Merge remote-tracking branch 'upstream/sycl' into warn

ef66522

sarnex temporarily deployed to WindowsCILock November 30, 2023 16:11 — with GitHub Actions Inactive

sarnex temporarily deployed to WindowsCILock November 30, 2023 16:41 — with GitHub Actions Inactive

premanandrao reviewed Dec 1, 2023

View reviewed changes

address feedback

5d3075b

Signed-off-by: Sarnie, Nick <[email protected]>

sarnex had a problem deploying to WindowsCILock December 1, 2023 15:23 — with GitHub Actions Failure

fix lit test

0517ac1

Signed-off-by: Sarnie, Nick <[email protected]>

sarnex temporarily deployed to WindowsCILock December 1, 2023 15:34 — with GitHub Actions Inactive

sarnex temporarily deployed to WindowsCILock December 1, 2023 16:04 — with GitHub Actions Inactive

premanandrao approved these changes Dec 1, 2023

View reviewed changes

smanna12 approved these changes Dec 1, 2023

View reviewed changes

aelovikov-intel merged commit ea6a3a3 into intel:sycl Dec 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SYCL][Driver] Add deprecated warning for backend GRF options on PVC #12029

[SYCL][Driver] Add deprecated warning for backend GRF options on PVC #12029

Uh oh!

sarnex commented Nov 28, 2023 •

edited

Loading

Uh oh!

sarnex commented Nov 29, 2023 •

edited

Loading

Uh oh!

sarnex Nov 29, 2023

Uh oh!

mdtoguchi Nov 29, 2023

Uh oh!

sarnex Nov 29, 2023

Uh oh!

sarnex Nov 29, 2023

Uh oh!

mdtoguchi Nov 29, 2023

Uh oh!

mdtoguchi Nov 29, 2023

Uh oh!

sarnex Nov 29, 2023

Uh oh!

mdtoguchi Nov 29, 2023

Uh oh!

mdtoguchi Nov 29, 2023

Uh oh!

sarnex commented Dec 1, 2023

Uh oh!

premanandrao Dec 1, 2023

Uh oh!

sarnex Dec 1, 2023

Uh oh!

sarnex commented Dec 1, 2023

Uh oh!

sarnex commented Dec 1, 2023

Uh oh!

Uh oh!

	"using %0 to set GRF mode on PVC hardware is deprecated; use -ftarget-register-alloc-mode=pvc:%1">,
	"using '%0' to set GRF mode on PVC hardware is deprecated; use '-ftarget-register-alloc-mode=pvc:%1'">,


		int main() {
		}

[SYCL][Driver] Add deprecated warning for backend GRF options on PVC #12029

[SYCL][Driver] Add deprecated warning for backend GRF options on PVC #12029

Uh oh!

Conversation

sarnex commented Nov 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sarnex commented Nov 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sarnex commented Dec 1, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sarnex commented Dec 1, 2023

Uh oh!

sarnex commented Dec 1, 2023

Uh oh!

Uh oh!

sarnex commented Nov 28, 2023 •

edited

Loading

sarnex commented Nov 29, 2023 •

edited

Loading