[SYCL] Fix operators for bool swizzled vec
#12001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c3a9615 added `CommonDataT` to fix an issue where results were truncated if an operand had a larger type than the result. As `CommonDataT` uses `std::common_type_t` of the left and right operands, it ignores `DataT`. This causes an issue for cases where `CommonDataT = bool` and `DataT != bool` since the operation result will be implicitly converted from `DataT` to `bool`. This change adds `DataT` to set of types used to define `CommonDataT`. Cases where the operands were `bool` type will now have the correct result rather than `1`. Fixes intel#11995. Signed-off-by: Michael Aziz <[email protected]>
0x12CC
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Michael Aziz <[email protected]>
Signed-off-by: Michael Aziz <[email protected]>
0x12CC
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Michael Aziz <[email protected]>
Signed-off-by: Michael Aziz <[email protected]>
Co-authored-by: aelovikov-intel <[email protected]>
Signed-off-by: Michael Aziz <[email protected]>
0x12CC
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
approved these changes
Nov 28, 2023
|
The failing test is the following: It's unrelated to this PR and was reported in #12011. @intel/llvm-gatekeepers, can this be merged? |
|
I'm not sure why it's failing but I'll try to reproduce the error. |
|
Cool thx |
|
Failure should be fixed with #12040. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c3a9615 added
CommonDataTto fix an issue where results were truncated if an operand had a larger type than the result. AsCommonDataTusesstd::common_type_tof the left and right operands, it ignoresDataT. This causes an issue for cases whereCommonDataT = boolandDataT != boolsince the operation result will be implicitly converted fromDataTtobool.This change adds
DataTto set of types used to defineCommonDataT. Cases where the operands werebooltype will now have the correct result rather than1. Fixes #11995.