[SYCL][E2E] add the FP16 tests in marray_geometric

[jinz2014]

Thank you for your review.

[cperkinsintel]

I haven't seen the test results complete yet, but this looks good.

[jinz2014]

I haven't seen the test results complete yet, but this looks good.

could you please explain "test results not complete yet" ?

[cperkinsintel]

@jinz2014 - sure. I simply meant that the CI had not yet run all the tests (including your updated one). So my approval is conditional on the tests passing ( and I don't expect any problem on that front)

[jinz2014]

The compiler errors are the same as those reported in #12058

[KseniyaTikhomirova]

@jinz2014 hi, tests are failing for all platforms even with -fpreview-breaking-changes flag. Could you please take a look?

[jinz2014]

@KseniyaTikhomirova Could you please point out where the flag is added for the AMD HIP build ?

Reference #11929

[KseniyaTikhomirova]

@KseniyaTikhomirova Could you please point out where the flag is added for the AMD HIP build ?

Reference #11929

@jinz2014 hi, I would start from test run on OCL/L0 on our HW. It is also failing. I guess the problem could be that your have lines 1-2 not removed/unchanged, with no any flags, and sycl::cross for sycl::half is still involved in compilation.

[jinz2014]

@KseniyaTikhomirova Could you please point out where the flag is added for the AMD HIP build ?
Reference #11929

@jinz2014 hi, I would start from test run on OCL/L0 on our HW. It is also failing. I guess the problem could be that your have lines 1-2 not removed/unchanged, with no any flags, and sycl::cross for sycl::half is still involved in compilation.

I deleted the first two lines. Thanks.

[KseniyaTikhomirova]

@KseniyaTikhomirova Could you please point out where the flag is added for the AMD HIP build ?
Reference #11929

@jinz2014 hi, I would start from test run on OCL/L0 on our HW. It is also failing. I guess the problem could be that your have lines 1-2 not removed/unchanged, with no any flags, and sycl::cross for sycl::half is still involved in compilation.

I deleted the first two lines. Thanks.

I clarified more details about that.
I would suggest to keep that lines to not reduce coverage. You can use __INTEL_PREVIEW_BREAKING_CHANGES define to wrap the code you added, the code that needs -fpreview-breaking-changes to be enabled to fix complication failures for initial scenario and properly add yours.

[jinz2014]

@KseniyaTikhomirova Could you please point out where the flag is added for the AMD HIP build ?
Reference #11929

@jinz2014 hi, I would start from test run on OCL/L0 on our HW. It is also failing. I guess the problem could be that your have lines 1-2 not removed/unchanged, with no any flags, and sycl::cross for sycl::half is still involved in compilation.

I deleted the first two lines. Thanks.

I clarified more details about that. I would suggest to keep that lines to not reduce coverage. You can use __INTEL_PREVIEW_BREAKING_CHANGES define to wrap the code you added, the code that needs -fpreview-breaking-changes to be enabled to fix complication failures for initial scenario and properly add yours.

Thanks for the suggestions.