[SYCL][E2E] Fix preview flag detection for CUDA and HIP #11929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The detection of support for -fpreview-breaking-changes was failing in E2E unintentionally. This commit fixes this detection. Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
commented
Nov 17, 2023
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
approved these changes
Nov 17, 2023
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@npmiller - It looks like something might be broken for vectors on HIP and CUDA hidden behind broken testing of the preview flag. Could you help investigate? Note: Since it only affects vec and that math builtins behind the flags were just cleanly moved, I suspect it has more to do with #11697 than the builtins. Tag @cperkinsintel for awareness. |
steffenlarsen
added a commit
to steffenlarsen/llvm
that referenced
this pull request
Nov 22, 2023
The preview flag testing for E2E testing is currently broken. intel#11929 attempts to fix it but has shown that some breakages in CUDA and HIP have been hidden behind the broken testing. To allow for proper testing while these failures are being investigated, this PR implements the fixes from intel#11929 with the caveat that they do not apply when HIP and CUDA devices are part of the testing. This is a temporary solution and does *not* replace intel#11929. Signed-off-by: Larsen, Steffen <[email protected]>
ldrumm
reviewed
Nov 22, 2023
|
Hi @steffenlarsen, it seems like the second RUN lit command (the one with Here is an example fix for --- a/sycl/test-e2e/Basic/built-ins/vec_common.cpp
+++ b/sycl/test-e2e/Basic/built-ins/vec_common.cpp
@@ -1,6 +1,6 @@
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out
-// RUN: %if preview-breaking-changes-supported %{ %clangxx -fsycl -fpreview-breaking-changes %s -o %t2.out %}
+// RUN: %if preview-breaking-changes-supported %{ %{build} -fpreview-breaking-changes -o %t2.out %}
// RUN: %if preview-breaking-changes-supported %{ %{run} %t2.out %}
#ifdef _WIN32
I'd be happy to include here the whole patch but Github doesn't allow me to |
steffenlarsen
added a commit
that referenced
this pull request
Nov 23, 2023
…#11978) The preview flag testing for E2E testing is currently broken. #11929 attempts to fix it but has shown that some breakages in CUDA and HIP have been hidden behind the broken testing. To allow for proper testing while these failures are being investigated, this PR implements the fixes from #11929 with the caveat that they do not apply when HIP and CUDA devices are part of the testing. This is a temporary solution and does *not* replace #11929. --------- Signed-off-by: Larsen, Steffen <[email protected]> Co-authored-by: Chris Perkins <[email protected]>
Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
changed the title
Signed-off-by: Larsen, Steffen <[email protected]>
Good catch, @konradkusiak97 ! That would definitely do it. I've pushed fixes to all the cases I could find with this. Let's hope that's the problem. Thanks a ton! |
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Looks like that was exactly the issue. Thanks again, @konradkusiak97 ! |
steffenlarsen
added a commit
that referenced
this pull request
Nov 23, 2023
This commit refactors the way we define source programs used to detect the availability of libraries in SYCL e2e LIT testing. Suggestion by @ldrumm in #11929 (comment). --------- Signed-off-by: Larsen, Steffen <[email protected]> Co-authored-by: Dmitry Vodopyanov <[email protected]>
aelovikov-intel
approved these changes
Nov 27, 2023
7 tasks
steffenlarsen
added a commit
to steffenlarsen/llvm
that referenced
this pull request
Jan 8, 2024
The detection of support for -fpreview-breaking-changes was failing in E2E unintentionally. This commit fixes this detection. --------- Signed-off-by: Larsen, Steffen <[email protected]> (cherry picked from commit bc30bef)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The detection of support for -fpreview-breaking-changes was failing in E2E unintentionally. This commit fixes this detection.