5.1.0 builtin and preview flag cherry-picks #12323
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recently added builtin definitions were not part of the breaking release, so to avoid API breaking changes for the next minor release this patch reintroduces the old definition of builtins and hides the new definitions behind the -fpreview-breaking-changes compiler option. --------- Signed-off-by: Larsen, Steffen <[email protected]> (cherry picked from commit a2f0221)
The preview flag was intended to be used in a number of builtins tests but were not correctly added to the build steps. This commit amends these tests. --------- Signed-off-by: Larsen, Steffen <[email protected]> (cherry picked from commit cee6122)
The detection of support for -fpreview-breaking-changes was failing in E2E unintentionally. This commit fixes this detection. --------- Signed-off-by: Larsen, Steffen <[email protected]> (cherry picked from commit bc30bef)
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Signed-off-by: Larsen, Steffen <[email protected]>
|
Looks like the old lint is still enabled for this branch. Tag @stdale-intel . |
|
Ping @stdale-intel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks of: