Skip to content

[SYCL][E2E] Move XFAIL to driver check in get_backend.cpp #12130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2023
Merged

[SYCL][E2E] Move XFAIL to driver check in get_backend.cpp #12130

merged 1 commit into from
Dec 11, 2023

Conversation

sarnex
Copy link
Contributor

@sarnex sarnex commented Dec 8, 2023

It passes with a newer driver so just check for that.

@sarnex sarnex changed the title [SYCL][E2E] Move XFAIL to driver change in get_backend.cpp [SYCL][E2E] Move XFAIL to driver check in get_backend.cpp Dec 8, 2023
@sarnex
Copy link
Contributor Author

sarnex commented Dec 8, 2023 

********************
Unexpectedly Passed Tests (2):
  SYCL :: Graph/Explicit/work_group_size_prop.cpp
  SYCL :: Graph/RecordReplay/work_group_size_prop.cpp

Not related

@sarnex sarnex marked this pull request as ready for review December 8, 2023 19:48
@sarnex sarnex requested a review from a team as a code owner December 8, 2023 19:48
@sarnex
Copy link
Contributor Author

sarnex commented Dec 11, 2023

@intel/llvm-gatekeepers This one should be ready for merge, CUDA fail not related. Thanks!

@steffenlarsen steffenlarsen merged commit e82769a into intel:sycl Dec 11, 2023
@aelovikov-intel
Copy link
Contributor

We've updated the driver and the test started to fail again: https://github.com/intel/llvm/actions/runs/7643052323

@sarnex , do you remember how you found the version to check for?

@aelovikov-intel aelovikov-intel mentioned this pull request Jan 25, 2024
Merged
@aelovikov-intel
Copy link
Contributor

@sarnex, ping.

@sarnex
Copy link
Contributor Author

sarnex commented Jan 26, 2024

@aelovikov-intel Sorry, somehow I missed the email. I don't remember how but I'll fix this again

@sarnex
Copy link
Contributor Author

sarnex commented Jan 26, 2024

#12511

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aelovikov-intel aelovikov-intel aelovikov-intel approved these changes

@cperkinsintel cperkinsintel Awaiting requested review from cperkinsintel cperkinsintel is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarnex @aelovikov-intel @steffenlarsen