[SYCL][Doc]Editorial changes "if_architecture_is" #12258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes some editorial changes to the "if_architecture_is" extension specification. None of the APIs changed, so this has no effect on the implementation. I'm making this in preparation for some new APIs that I will soon add to this extension. * Eliminate redundancy with the `architecture` enumeration. The code synopsis no longer duplicates the enumerators. These are now entirely defined in the table. * Add some missing entries to the table defining the enumerators, and fix some obvious cut-and-paste errors with the descriptions. * Update the function descriptions to our new format, using subsections `Constraints`, `Preconditions`, etc. * User our new style where we make a line break after every sentence.
Pennycook
approved these changes
Jan 19, 2024
sycl/doc/extensions/experimental/sycl_ext_oneapi_device_architecture.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_device_architecture.asciidoc
Outdated
Show resolved
Hide resolved
Co-authored-by: John Pennycook <[email protected]>
|
@intel/llvm-gatekeepers I think this PR is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes some editorial changes to the "if_architecture_is" extension specification. None of the APIs changed, so this has no effect on the implementation. I'm making this in preparation for some new APIs that I will soon add to this extension.
Eliminate redundancy with the
architectureenumeration. The code synopsis no longer duplicates the enumerators. These are now entirely defined in the table.Add some missing entries to the table defining the enumerators, and fix some obvious cut-and-paste errors with the descriptions.
Update the function descriptions to our new format, using subsections
Constraints,Preconditions, etc.Use our new style where we make a line break after every sentence.