Skip to content

[SYCL][Doc]Comparisons in "if_architecture_is" #12259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2024
Merged

[SYCL][Doc]Comparisons in "if_architecture_is" #12259

merged 1 commit into from
Jan 30, 2024

Conversation

gmlueck
Copy link
Contributor

@gmlueck gmlueck commented Dec 28, 2023

Update the "if_architecture_is" extension spec to allow greater-than and less-than comparisons between architecture values.

@gmlueck gmlueck requested a review from a team as a code owner December 28, 2023 22:22
@gmlueck
[SYCL][Doc]Comparisons in "if_architecture_is"
10921c3 
Update the "if_architecture_is" extension spec to allow greater-than
and less-than comparisons between architecture values.
@gmlueck gmlueck force-pushed the gmlueck/arch-comparison branch from 775f6b8 to 10921c3 Compare January 19, 2024 22:08
@gmlueck gmlueck requested review from a team and bader as code owners January 19, 2024 22:08
@gmlueck gmlueck requested review from bso-intel and sergey-semenov and removed request for a team January 19, 2024 22:08
@gmlueck gmlueck changed the base branch from gmlueck/arch-editorial to sycl January 19, 2024 22:09
@gmlueck gmlueck removed request for a team, bader, bso-intel and sergey-semenov January 19, 2024 22:19
@gmlueck
Copy link
Contributor Author

gmlueck commented Jan 21, 2024

@intel/llvm-gatekeepers do you have any suggestion about the CI failure? I think CI is somehow confused here. It is probably related to the way I created this PR. I initially created it as a "stacked" PR on top of #12258. (I.e. the destination branch of this PR was the branch containing #12258. Thus, this PR showed only the incremental changes.) Once #12258 was merged, I rebased this PR on top of it, and I also changed the destination branch of this PR to be "sycl", which is the normal destination branch for PRs in this repo.

My guess is that this somehow confused the CI system. Is there some way to rerun the CI tests from scratch?

@aelovikov-intel
Copy link
Contributor

My guess is that this somehow confused the CI system. Is there some way to rerun the CI tests from scratch?

My best and only guess would be to close/re-open this PR.

@gmlueck gmlueck closed this Jan 22, 2024
@gmlueck gmlueck reopened this Jan 22, 2024
zettai-reido
zettai-reido approved these changes Jan 25, 2024
View reviewed changes
Copy link

@zettai-reido zettai-reido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I would have renamed fallback to generic at L990 because fallback usually is not what is decided in the kernel.

@dm-vodopyanov
Copy link
Contributor

@intel/dpcpp-specification-reviewers, friendly ping

steffenlarsen
steffenlarsen approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dm-vodopyanov
Copy link
Contributor

Looks good.

I would have renamed fallback to generic at L990 because fallback usually is not what is decided in the kernel.

Will be addressed in the separate PR.

@dm-vodopyanov dm-vodopyanov merged commit 3613ca3 into intel:sycl Jan 30, 2024
dm-vodopyanov added a commit to dm-vodopyanov/llvm that referenced this pull request Jan 30, 2024
@dm-vodopyanov
[SYCL][Doc][NFC] Rename 'fallback' to 'generic' in two specs
a4024e7 
The change was made based on a comment
intel#12259 (review)
@dm-vodopyanov dm-vodopyanov mentioned this pull request Jan 30, 2024
Merged
@aelovikov-intel
Copy link
Contributor

Post commit failures (for future references/searches):

# Arc GPU:
Failed Tests (2):
  SYCL :: ESIMD/lsc/local_accessor_atomic_smoke_cmpxchg.cpp
  SYCL :: ESIMD/lsc/lsc_slm_atomic_smoke.cpp

dm-vodopyanov added a commit that referenced this pull request Feb 5, 2024
@dm-vodopyanov
[SYCL][Doc][NFC] Rename 'fallback' to 'generic' in two specs (#12544)
015deb1 
The change was made based on a comment
#12259 (review)
@gmlueck gmlueck deleted the gmlueck/arch-comparison branch February 16, 2024 21:31
dm-vodopyanov added a commit to dm-vodopyanov/llvm that referenced this pull request Feb 17, 2024
@dm-vodopyanov
[SYCL] Implement device arch comparison according to sycl_ext_oneapi_…
2c4f5f7 
…device_architecture spec update

This patch implements device AOT and host APIs for device architecture
comparison in accordance to [spec update](intel#12259)
@dm-vodopyanov dm-vodopyanov mentioned this pull request Feb 17, 2024
Merged
dm-vodopyanov added a commit that referenced this pull request Mar 6, 2024
@dm-vodopyanov
[SYCL] Implement device arch comparison according to sycl_ext_oneapi_…
6844546 
…device_architecture spec update (#12752)

This patch implements device AOT and host APIs for device architecture
comparison in accordance to [spec
update](#12259)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@zettai-reido zettai-reido zettai-reido approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gmlueck @aelovikov-intel @dm-vodopyanov @steffenlarsen @zettai-reido