Skip to content

[SYCL][Fusion][Tests] Test group functions, group algoriths and reduction #12402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

victor-eds
Copy link
Contributor

Add tests for fusing kernels with the same ND-range using group functions, group algorithms and reductions.

@victor-eds victor-eds self-assigned this Jan 16, 2024
@victor-eds victor-eds requested a review from a team as a code owner January 16, 2024 12:58
@victor-eds
Copy link
Contributor Author

Failure unrelated to this change

…tions

Add tests for fusing kernels with the same ND-range using group
functions, group algorithms and reductions.

Signed-off-by: Victor Perez <[email protected]>
@victor-eds
Copy link
Contributor Author

@intel/llvm-gatekeepers can I get this merged, please?

@sommerlukas sommerlukas merged commit f62def0 into intel:sycl Jan 22, 2024
@victor-eds victor-eds deleted the sycl-fusion-tests branch January 22, 2024 15:01
@aelovikov-intel
Copy link
Contributor

Looks like this new test fails in Nightly every day since its introduction: https://github.com/intel/llvm/actions/runs/7620444887/job/20755732583

@victor-eds , @sommerlukas , please fix or disable the test while investigation is in progress.

@sommerlukas
Copy link
Contributor

Looks like this new test fails in Nightly every day since its introduction: https://github.com/intel/llvm/actions/runs/7620444887/job/20755732583

@victor-eds , @sommerlukas , please fix or disable the test while investigation is in progress.

Thanks for reporting this @aelovikov-intel, we'll investigate.

Are there any notable differences in the Nightly pipeline, as the test doesn't seem to fail in pre-commit here or post-commit since then?

@aelovikov-intel
Copy link
Contributor

Are there any notable differences in the Nightly pipeline, as the test doesn't seem to fail in pre-commit here or post-commit since then?

Nothing applicable to this test comes to my mind. We have different XFAIL processing (see test-e2e/README), but that is irrelevant here.

@aelovikov-intel
Copy link
Contributor

we'll investigate.

If the timeline is unclear, please disable the test for now.

@sommerlukas
Copy link
Contributor

we'll investigate.

If the timeline is unclear, please disable the test for now.

We have a PR for disabling: #12540

@sommerlukas
Copy link
Contributor

Are there any notable differences in the Nightly pipeline, as the test doesn't seem to fail in pre-commit here or post-commit since then?

Nothing applicable to this test comes to my mind. We have different XFAIL processing (see test-e2e/README), but that is irrelevant here.

As the problem seems to only occur for OpenCL CPU, the relevant difference might be that OpenCL CPU is only tested in nightly.

@aelovikov-intel
Copy link
Contributor

As the problem seems to only occur for OpenCL CPU, the relevant difference might be that OpenCL CPU is only tested in nightly.

We do run opencl:cpu in pre-commit, it's part of the Intel Gen12 runner (uses three devices at once - opencl cpu/gpu + level_zero gpu).

I suspect the difference is that in Nightly it's the AMD CPU and not Intel for opencl:cpu target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants