-
Notifications
You must be signed in to change notification settings - Fork 788
[SYCL][Fusion][Tests] Test group functions, group algoriths and reduction #12402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,75 @@ | ||
// RUN: %{build} -fsycl-embed-ir -I . -o %t.out | ||
// RUN: %{run} %t.out | ||
|
||
#include "../helpers.hpp" | ||
#include "support.h" | ||
#include <algorithm> | ||
#include <cassert> | ||
#include <iostream> | ||
#include <numeric> | ||
#include <sycl/sycl.hpp> | ||
|
||
// COM: Check all_of works with kernel fusion. | ||
|
||
using namespace sycl; | ||
|
||
template <class Predicate> class all_of_kernel; | ||
|
||
struct IsEven { | ||
bool operator()(int i) const { return (i % 2) == 0; } | ||
}; | ||
|
||
template <typename InputContainer, typename OutputContainer, class Predicate> | ||
void test(queue q, InputContainer input, OutputContainer output, | ||
Predicate pred) { | ||
typedef class all_of_kernel<Predicate> kernel_name; | ||
size_t N = input.size(); | ||
size_t G = 64; | ||
{ | ||
buffer<int> in_buf(input.data(), input.size()); | ||
buffer<bool> out_buf(output.data(), output.size()); | ||
|
||
ext::codeplay::experimental::fusion_wrapper fw{q}; | ||
fw.start_fusion(); | ||
|
||
iota(q, in_buf, 0); | ||
|
||
q.submit([&](handler &cgh) { | ||
accessor in{in_buf, cgh, sycl::read_only}; | ||
accessor out{out_buf, cgh, sycl::write_only, sycl::no_init}; | ||
cgh.parallel_for<kernel_name>(nd_range<1>(G, G), [=](nd_item<1> it) { | ||
group<1> g = it.get_group(); | ||
int lid = it.get_local_id(0); | ||
out[0] = all_of_group(g, pred(in[lid])); | ||
out[1] = all_of_group(g, in[lid], pred); | ||
out[2] = joint_all_of( | ||
g, in.template get_multi_ptr<access::decorated::no>(), | ||
in.template get_multi_ptr<access::decorated::no>() + N, pred); | ||
}); | ||
}); | ||
|
||
complete_fusion_with_check( | ||
fw, ext::codeplay::experimental::property::no_barriers{}); | ||
} | ||
bool expected = std::all_of(input.begin(), input.end(), pred); | ||
assert(output[0] == expected); | ||
assert(output[1] == expected); | ||
assert(output[2] == expected); | ||
} | ||
|
||
int main() { | ||
queue q{ext::codeplay::experimental::property::queue::enable_fusion{}}; | ||
if (!isSupportedDevice(q.get_device())) { | ||
std::cout << "Skipping test\n"; | ||
return 0; | ||
} | ||
|
||
constexpr int N = 128; | ||
std::array<int, N> input; | ||
std::array<bool, 3> output; | ||
std::fill(output.begin(), output.end(), false); | ||
|
||
test(q, input, output, IsEven()); | ||
|
||
std::cout << "Test passed." << std::endl; | ||
} |
181 changes: 181 additions & 0 deletions
181
sycl/test-e2e/KernelFusion/GroupAlgorithm/exclusive_scan.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,181 @@ | ||
// RUN: %{build} -fsycl-embed-ir -I . -o %t.out | ||
// RUN: %{run} %t.out | ||
|
||
#include "../../helpers.hpp" | ||
#include "../helpers.hpp" | ||
#include "support.h" | ||
#include <algorithm> | ||
#include <cassert> | ||
#include <iostream> | ||
#include <limits> | ||
#include <numeric> | ||
#include <sycl/sycl.hpp> | ||
#include <vector> | ||
using namespace sycl; | ||
|
||
// COM: Check exclusive_scan works with fusion | ||
|
||
template <class SpecializationKernelName, int TestNumber> | ||
class exclusive_scan_kernel; | ||
|
||
template <typename BinaryOperation> class K0; | ||
template <typename BinaryOperation> class K1; | ||
template <typename BinaryOperation> class K2; | ||
template <typename BinaryOperation> class K3; | ||
|
||
template <typename InputContainer, typename OutputContainer, | ||
class BinaryOperation> | ||
void test(queue q, InputContainer input, OutputContainer output, | ||
BinaryOperation binary_op, | ||
typename OutputContainer::value_type identity) { | ||
typedef typename InputContainer::value_type InputT; | ||
typedef typename OutputContainer::value_type OutputT; | ||
OutputT init = 42; | ||
size_t N = input.size(); | ||
size_t G = 64; | ||
std::vector<OutputT> expected(N); | ||
{ | ||
buffer<InputT> in_buf(input.data(), input.size()); | ||
buffer<OutputT> out_buf(output.data(), output.size()); | ||
ext::codeplay::experimental::fusion_wrapper fw{q}; | ||
fw.start_fusion(); | ||
|
||
iota(q, in_buf, 0); | ||
|
||
q.submit([&](handler &cgh) { | ||
accessor in{in_buf, cgh, sycl::read_only}; | ||
accessor out{out_buf, cgh, sycl::write_only, sycl::no_init}; | ||
cgh.parallel_for<K0<BinaryOperation>>( | ||
nd_range<1>(G, G), [=](nd_item<1> it) { | ||
group<1> g = it.get_group(); | ||
int lid = it.get_local_id(0); | ||
out[lid] = exclusive_scan_over_group(g, in[lid], binary_op); | ||
}); | ||
}); | ||
|
||
complete_fusion_with_check( | ||
fw, ext::codeplay::experimental::property::no_barriers{}); | ||
} | ||
emu::exclusive_scan(input.begin(), input.begin() + G, expected.begin(), | ||
identity, binary_op); | ||
assert(std::equal(output.begin(), output.begin() + G, expected.begin())); | ||
|
||
// Fill to test fusion again | ||
std::fill(input.begin(), input.end(), 0); | ||
|
||
{ | ||
buffer<InputT> in_buf(input.data(), input.size()); | ||
buffer<OutputT> out_buf(output.data(), output.size()); | ||
|
||
ext::codeplay::experimental::fusion_wrapper fw{q}; | ||
fw.start_fusion(); | ||
|
||
iota(q, in_buf, 0); | ||
|
||
q.submit([&](handler &cgh) { | ||
accessor in{in_buf, cgh, sycl::read_only}; | ||
accessor out{out_buf, cgh, sycl::write_only, sycl::no_init}; | ||
cgh.parallel_for<K1<BinaryOperation>>( | ||
nd_range<1>(G, G), [=](nd_item<1> it) { | ||
group<1> g = it.get_group(); | ||
int lid = it.get_local_id(0); | ||
out[lid] = exclusive_scan_over_group(g, in[lid], init, binary_op); | ||
}); | ||
}); | ||
|
||
complete_fusion_with_check( | ||
fw, ext::codeplay::experimental::property::no_barriers{}); | ||
} | ||
emu::exclusive_scan(input.begin(), input.begin() + G, expected.begin(), init, | ||
binary_op); | ||
assert(std::equal(output.begin(), output.begin() + G, expected.begin())); | ||
|
||
// Fill to test fusion again | ||
std::fill(input.begin(), input.end(), 0); | ||
|
||
{ | ||
buffer<InputT> in_buf(input.data(), input.size()); | ||
buffer<OutputT> out_buf(output.data(), output.size()); | ||
|
||
ext::codeplay::experimental::fusion_wrapper fw{q}; | ||
fw.start_fusion(); | ||
|
||
iota(q, in_buf, 0); | ||
|
||
q.submit([&](handler &cgh) { | ||
accessor in{in_buf, cgh, sycl::read_only}; | ||
accessor out{out_buf, cgh, sycl::write_only, sycl::no_init}; | ||
cgh.parallel_for<K2<BinaryOperation>>( | ||
nd_range<1>(G, G), [=](nd_item<1> it) { | ||
group<1> g = it.get_group(); | ||
joint_exclusive_scan( | ||
g, in.template get_multi_ptr<access::decorated::no>(), | ||
in.template get_multi_ptr<access::decorated::no>() + N, | ||
out.template get_multi_ptr<access::decorated::no>(), binary_op); | ||
}); | ||
}); | ||
complete_fusion_with_check( | ||
fw, ext::codeplay::experimental::property::no_barriers{}); | ||
} | ||
emu::exclusive_scan(input.begin(), input.begin() + N, expected.begin(), | ||
identity, binary_op); | ||
assert(std::equal(output.begin(), output.begin() + N, expected.begin())); | ||
|
||
// Fill to test fusion again | ||
std::fill(input.begin(), input.end(), 0); | ||
|
||
{ | ||
buffer<InputT> in_buf(input.data(), input.size()); | ||
buffer<OutputT> out_buf(output.data(), output.size()); | ||
ext::codeplay::experimental::fusion_wrapper fw{q}; | ||
fw.start_fusion(); | ||
|
||
iota(q, in_buf, 0); | ||
|
||
q.submit([&](handler &cgh) { | ||
accessor in{in_buf, cgh, sycl::read_only}; | ||
accessor out{out_buf, cgh, sycl::write_only, sycl::no_init}; | ||
cgh.parallel_for<K3<BinaryOperation>>( | ||
nd_range<1>(G, G), [=](nd_item<1> it) { | ||
group<1> g = it.get_group(); | ||
joint_exclusive_scan( | ||
g, in.template get_multi_ptr<access::decorated::no>(), | ||
in.template get_multi_ptr<access::decorated::no>() + N, | ||
out.template get_multi_ptr<access::decorated::no>(), init, | ||
binary_op); | ||
}); | ||
}); | ||
complete_fusion_with_check( | ||
fw, ext::codeplay::experimental::property::no_barriers{}); | ||
} | ||
emu::exclusive_scan(input.begin(), input.begin() + N, expected.begin(), init, | ||
binary_op); | ||
assert(std::equal(output.begin(), output.begin() + N, expected.begin())); | ||
} | ||
|
||
int main() { | ||
queue q{ext::codeplay::experimental::property::queue::enable_fusion{}}; | ||
if (!isSupportedDevice(q.get_device())) { | ||
std::cout << "Skipping test\n"; | ||
return 0; | ||
} | ||
|
||
constexpr int N = 128; | ||
std::array<int, N> input; | ||
std::array<int, N> output; | ||
std::fill(output.begin(), output.end(), 0); | ||
|
||
test(q, input, output, sycl::plus<>(), 0); | ||
test(q, input, output, sycl::minimum<>(), std::numeric_limits<int>::max()); | ||
test(q, input, output, sycl::maximum<>(), std::numeric_limits<int>::lowest()); | ||
test(q, input, output, sycl::plus<int>(), 0); | ||
test(q, input, output, sycl::minimum<int>(), std::numeric_limits<int>::max()); | ||
test(q, input, output, sycl::maximum<int>(), | ||
std::numeric_limits<int>::lowest()); | ||
test(q, input, output, sycl::multiplies<int>(), 1); | ||
test(q, input, output, sycl::bit_or<int>(), 0); | ||
test(q, input, output, sycl::bit_xor<int>(), 0); | ||
test(q, input, output, sycl::bit_and<int>(), ~0); | ||
|
||
std::cout << "Test passed." << std::endl; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
#include <iostream> | ||
#include <sycl/sycl.hpp> | ||
|
||
using namespace sycl; | ||
using namespace sycl::ext::oneapi; | ||
|
||
bool isSupportedDevice(device D) { | ||
std::string PlatformName = | ||
D.get_platform().get_info<sycl::info::platform::name>(); | ||
if (PlatformName.find("CUDA") != std::string::npos) | ||
return true; | ||
|
||
if (PlatformName.find("Level-Zero") != std::string::npos) | ||
return true; | ||
|
||
if (PlatformName.find("OpenCL") != std::string::npos) { | ||
std::string Version = D.get_info<sycl::info::device::version>(); | ||
|
||
// Group collectives are mandatory in OpenCL 2.0 but optional in 3.0. | ||
Version = Version.substr(7, 3); | ||
if (Version >= "2.0" && Version < "3.0") | ||
return true; | ||
} | ||
|
||
return false; | ||
} | ||
|
||
template <typename T, typename S> bool equal(const T &x, const S &y) { | ||
// vec equal returns a vector of which components were equal | ||
if constexpr (sycl::detail::is_vec<T>::value) { | ||
for (int i = 0; i < x.size(); ++i) | ||
if (x[i] != y[i]) | ||
return false; | ||
return true; | ||
} else | ||
return x == y; | ||
} | ||
|
||
template <typename T1, typename T2> | ||
bool ranges_equal(T1 begin1, T1 end1, T2 begin2) { | ||
for (; begin1 != end1; ++begin1, ++begin2) | ||
if (!equal(*begin1, *begin2)) | ||
return false; | ||
return true; | ||
} |
64 changes: 64 additions & 0 deletions
64
sycl/test-e2e/KernelFusion/GroupFunctions/group_barrier.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
// RUN: %{build} -fsycl-embed-ir -o %t.out | ||
// RUN: %{run} %t.out | ||
|
||
// Test complete_fusion preserves barriers by launching a kernel that requires a | ||
// barrier for correctness. | ||
|
||
#include <sycl/sycl.hpp> | ||
|
||
#include "../helpers.hpp" | ||
|
||
using namespace sycl; | ||
|
||
class Kernel; | ||
|
||
int main() { | ||
constexpr size_t dataSize = 512; | ||
constexpr size_t localSize = 64; | ||
std::array<int, dataSize> in; | ||
std::array<int, dataSize> out; | ||
out.fill(0); | ||
|
||
queue q{ext::codeplay::experimental::property::queue::enable_fusion{}}; | ||
{ | ||
buffer<int> buff_in{in}; | ||
buffer<int> buff_out{out}; | ||
|
||
ext::codeplay::experimental::fusion_wrapper fw{q}; | ||
fw.start_fusion(); | ||
|
||
assert(fw.is_in_fusion_mode() && "Queue should be in fusion mode"); | ||
|
||
iota(q, buff_in, 0); | ||
|
||
// Needed implicit group barrier | ||
|
||
q.submit([&](handler &cgh) { | ||
accessor in(buff_in, cgh, read_only); | ||
accessor out(buff_out, cgh, write_only, no_init); | ||
local_accessor<int> lacc(localSize, cgh); | ||
cgh.parallel_for<Kernel>( | ||
nd_range<1>{{dataSize}, {localSize}}, [=](nd_item<1> i) { | ||
auto group = i.get_group(); | ||
if (i.get_local_id() == 0) { | ||
auto begin = in.begin() + static_cast<int64_t>( | ||
localSize * group.get_group_id(0)); | ||
auto end = begin + localSize; | ||
std::copy(begin, end, lacc.begin()); | ||
} | ||
// Test following barrier is preserved | ||
group_barrier(i.get_group()); | ||
out[i.get_global_id()] = lacc[i.get_local_id()]; | ||
}); | ||
}); | ||
|
||
complete_fusion_with_check(fw); | ||
} | ||
|
||
// Check the results | ||
for (int i = 0, end = dataSize; i < end; ++i) { | ||
assert(out[i] == i && "Computation error"); | ||
} | ||
|
||
return 0; | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.