[SYCL][FPGA] Refactor statments attributes to align with community the way we handle conflicting vs duplicate values #13146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e way we handle conflicting vs duplicate values This patch updates ExprArgument<> to use same routine CheckForDuplicateAttrs() that was added on intel#12243 to diagnose non-identical duplicates as a 'conflicting' loop attributes and suppresse duplicate errors in cases where the two match for FPGA SYCL attributes: [[intel::max_concurrency()]] and [[intel::initiation_interval()]] to align with clang community change (Ref: llvm/llvm-project#70762). Signed-off-by: Soumi Manna <[email protected]>
smanna12
changed the title
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
|
Thank you @premanandrao for reviews. |
|
The failing is unrelated to my patch. @intel/llvm-gatekeepers, could you please merge this PR? Thanks |
|
Ping @intel/llvm-gatekeepers, please merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates ExprArgument<> to use same routine CheckForDuplicateAttrs() that was added on #12243 to diagnose non-identical duplicates as a 'conflicting' loop attributes and suppresse duplicate errors in cases where the two match for FPGA SYCL attributes: [[intel::max_concurrency()]] and [[intel::initiation_interval()]] to align with clang community change (Ref: llvm/llvm-project#70762).