Skip to content

[CI] Refactor sycl-containers to use matrix #13292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Conversation

jsji
Copy link
Contributor

@jsji jsji commented Apr 4, 2024

Address review comments from #13272 (comment)

@jsji jsji self-assigned this Apr 4, 2024
@jsji jsji temporarily deployed to WindowsCILock April 4, 2024 22:24 — with GitHub Actions Inactive
@jsji jsji marked this pull request as ready for review April 4, 2024 22:35
@jsji jsji requested a review from a team as a code owner April 4, 2024 22:35
@jsji jsji temporarily deployed to WindowsCILock April 4, 2024 22:51 — with GitHub Actions Inactive
@jsji
Copy link
Contributor Author

jsji commented Apr 4, 2024

@intel/llvm-gatekeepers Please help to merge . Thanks.

@aelovikov-intel aelovikov-intel merged commit a318776 into sycl Apr 5, 2024
@aelovikov-intel aelovikov-intel deleted the refactorcontainer branch April 5, 2024 15:58
build_args: "use_latest=false"
- name: Intel Drivers (unstable) Ubuntu 22.04 Docker image
file: ubuntu2204_intel_drivers
tags: ubuntu2204_intel_drivers_unstable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this patch changes tags we used for uploading docker images.
@jsji, could you update the documentation https://github.com/intel/llvm/blob/sycl/sycl/doc/developer/DockerBKMs.md#sycl-containers-overview if it's needed, please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the tag for unstable is changed, but we never mentioned/use it anywhere in source tree/docs. So I don't think any updated needed. Let me know if there is some usage that I don't know.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update the doc to describe how to test with dev igc later when the whole workflow is enabled.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#13307 for the image update first.

jsji added a commit that referenced this pull request Apr 5, 2024
We renamed the unstable image in
#13292

Added new devigc image in #13272.
dm-vodopyanov pushed a commit that referenced this pull request Apr 9, 2024
We renamed the unstable image in
#13292

Added new devigc image in #13272.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants