Skip to content

[SYCL][Doc] Update new Intel driver docker images #13307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 9, 2024
Merged

Conversation

jsji
Copy link
Contributor

@jsji jsji commented Apr 5, 2024

We renamed the unstable image in
#13292

Added new devigc image in #13272.

We renamed the unstable image in
#13292

Added new devigc image in #13272.
@jsji jsji requested a review from a team as a code owner April 5, 2024 19:40
@jsji jsji self-assigned this Apr 5, 2024
@jsji jsji requested a review from bader April 5, 2024 20:51
@jsji jsji requested a review from bader April 5, 2024 22:23
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except a couple of nits.

@@ -40,16 +40,13 @@ The following containers are publicly available for DPC++ compiler development:
building DPC++ compiler from source.
- `ghcr.io/intel/llvm/ubuntu2204_intel_drivers`: contains everything from the
base container + pre-installed Intel drivers.
Intel drivers are downloaded from release/tag and saved in dependencies.json.
The image comes in three flavors:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The image comes in three flavors:
The image comes in three flavors/tags:

@@ -40,16 +40,13 @@ The following containers are publicly available for DPC++ compiler development:
building DPC++ compiler from source.
- `ghcr.io/intel/llvm/ubuntu2204_intel_drivers`: contains everything from the
base container + pre-installed Intel drivers.
Intel drivers are downloaded from release/tag and saved in dependencies.json.
The image comes in three flavors:
* `latest`: Intel drivers are downloaded from release/tag and saved in dependencies.json.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, keep line length <= 80 characters.

@jsji
Copy link
Contributor Author

jsji commented Apr 9, 2024

@intel/llvm-gatekeepers This is ready for merge. Thanks.

@dm-vodopyanov dm-vodopyanov changed the title [Doc] Update new intel driver docker images [SYCL][Doc] Update new Intel driver docker images Apr 9, 2024
@dm-vodopyanov dm-vodopyanov merged commit 5f4629b into sycl Apr 9, 2024
@aelovikov-intel aelovikov-intel deleted the docupdate branch April 9, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants