Skip to content

sycl-rel_5_2_0: Add non-null check before accessing pointer (#83459) #13353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

npmiller
Copy link
Contributor

Cherry-pick static analysis fix: llvm/llvm-project#83459

Add a check if RC is not null to ensure that a consecutive access is safe.

A static analyzer flagged this issue since hasVectorRegisters potentially dereferences RC.

Add a check if RC is not null to ensure that a consecutive access is
safe.

A static analyzer flagged this issue since hasVectorRegisters
potentially dereferences RC.
@npmiller npmiller requested a review from a team as a code owner April 10, 2024 16:24
Copy link
Contributor

@AlexeySachkov AlexeySachkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tagging @stdale-intel here:

  • we need to come up with some special [tag]s for release branch cherry-picks, because I was very confused at first about why a patch from Mar 7th is still not in our sycl branch
  • no pre-commit checks were launched - this is a critical for a release branch, I think
  • do we need a more strict gatekeeping policy for release branches?

@npmiller npmiller changed the title Add non-null check before accessing pointer (#83459) sycl-rel_5_2_0: Add non-null check before accessing pointer (#83459) Apr 15, 2024
@npmiller npmiller closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants