Skip to content

[TEST][CI] Enable pr-code-format on branches in intel/llvm (#13101) #13402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

npmiller
Copy link
Contributor

Testing to see if this trigger the CI, we may need to cherry-pick the branch matching on the release branch

@npmiller npmiller requested a review from a team as a code owner April 15, 2024 12:56
@npmiller
Copy link
Contributor Author

That didn't seem to trigger any extra check, @aelovikov-intel do you know if we need to have the config changes on sycl-rel-5_2_0, this PR didn't trigger anything either: #13353

@@ -3,6 +3,9 @@ on:
pull_request_target:
branches:
- main
- sycl
- sycl-devops-pr/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- sycl-devops-pr/**

@aelovikov-intel
Copy link
Contributor

That didn't seem to trigger any extra check, @aelovikov-intel do you know if we need to have the config changes on sycl-rel-5_2_0, this PR didn't trigger anything either: #13353

This workflow has 'pull_request_target' trigger, so the change has to be merged first to take any effect.

@npmiller
Copy link
Contributor Author

That makes sense, it is merged in the sycl branch, but didn't make it into the sycl-rel-5_2_0 branch, that's why I was wondering if it might work anyway or if we need to cherry-pick.

I'll gather the patches that updated this and open a big cherry-pick PR

@npmiller
Copy link
Contributor Author

Actually this was the only pre-commit workflow that didn't have the branch matching, the others have it but the jobs aren't getting triggered anyway, so not sure what's going on then

@npmiller npmiller closed this Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants