Skip to content

[TEST-E2E] Avoid conflicts of Windows headers with std::max. #13637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2024
Merged

[TEST-E2E] Avoid conflicts of Windows headers with std::max. #13637

merged 1 commit into from
May 24, 2024

Conversation

mmoadeli
Copy link
Contributor

@mmoadeli mmoadeli commented May 2, 2024

Avoid conflicts of Windows headers with std::max using #define NOMINMAX
The patch fixes the build error seen in kernel_win.cpp

@mmoadeli mmoadeli requested a review from a team as a code owner May 2, 2024 10:41
@mmoadeli mmoadeli temporarily deployed to WindowsCILock May 2, 2024 10:50 — with GitHub Actions Inactive
@mmoadeli mmoadeli temporarily deployed to WindowsCILock May 2, 2024 11:10 — with GitHub Actions Inactive
@ldrumm ldrumm merged commit ecef842 into intel:sycl May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alcpz Alcpz Alcpz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmoadeli @Alcpz @ldrumm