[SYCL][NATIVECPU] Allow building Native CPU with shared libraries #13830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizabethandrews
approved these changes
May 22, 2024
AlexeySachkov
approved these changes
Jun 4, 2024
smanna12
approved these changes
Jun 4, 2024
|
Hi @intel/dpcpp-esimd-reviewers, could you take a look at this PR? Thanks |
|
@intel/dpcpp-esimd-reviewers ping |
1 similar comment
|
@intel/dpcpp-esimd-reviewers ping |
uwedolinsky
approved these changes
Jul 2, 2024
|
kindly ping @intel/dpcpp-esimd-reviewers for review |
sarnex
approved these changes
Jul 3, 2024
|
Hi @intel/llvm-gatekeepers, this looks ready to merge, windows failure is infrastructural, see #14370 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently building Native CPU with shared libraries enabled leads to a CMake error when configuring: some components of the oneAPI Construction Kit depend on
LLVMPasses, and since they are also added aslink_librariestoSYCLLowerIR(whichLLVMPassesdepends on), that creates a circular dependency that is not allowed when building with shared libraries enabled.This PR addresses this by moving all the Native CPU components to a new folder (
SYCLNativeCPUUtils), that is not linked toLLVMPasses, thus breaking the circular dependencies.