-
Notifications
You must be signed in to change notification settings - Fork 788
[SYCL] Host device & queue removal (internal part, not breaking ABI) #14370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Host device & queue removal (internal part, not breaking ABI) #14370
Conversation
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
original PR was #14027 but I made a mistake during sycl branch merge caused addition of sycl commits to PR and requesting corresponding reviewers not related to my changes. |
@isaacault hi, may I ask you to approve it again? I spoiled my original PR #14027 (you approved it) and opened this one. Thank you. |
@KseniyaTikhomirova, I can help you to fix #14370. Ping me if you are interested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sycl/source/detail/bindless_images.cpp
LGTM.
CI failure seems related to #14248. I'm not sure what the fix is, but I've had luck working around this by frequently merging |
@intel/llvm-gatekeepers hi, Win E2E testing failed at the last step - infrastructure issue. could we merge this PR despite on this? Total Discovered Tests: 2091 |
Windows failure is after tests run and is infrastructural. Merging this. |
Monitoring post-commit shows MacOS build failure with unused var in program_impl. |
more fixes #14396 |
Host device support is deprecated long time ago. Although our internal host task & host accessor implementation was still using it.
This change eliminates it and remove possibility to create host queue/context and device. This brings the following changes:
ABI breaking changes to remove is_host methods and some SYCL_EXTERN stuff will be submitted separately.