Skip to content

[SYCL][Bindless][Doc] Rename interop related structs/funcs to external #14444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 44 commits into from
Jul 30, 2024
Merged

[SYCL][Bindless][Doc] Rename interop related structs/funcs to external #14444

merged 44 commits into from
Jul 30, 2024

Conversation

DBDuncan
Copy link
Contributor

@DBDuncan DBDuncan commented Jul 4, 2024

Rename related interop structs/funcs with "external" keyword over "interop" to align better with existing structs/funcs and other 3rd party APIs.

Remove "handle" keyword from imported external memory/semaphore objects to distinguish between 3rd party external handles and imported external handles.

@Seanst98 @DBDuncan
[SYCL][Bindless][Doc][ABI-Break] Rename interop related structs/funcs…
7125ba0 
… to external

Rename related interop structs/funcs with "external" keyword over
"interop" to align better with existing structs/funcs and other 3rd party
APIs.

Remove "handle" keyword from imported external memory/semaphore objects
to distinguish between 3rd party external handles and imported external
handles.
@DBDuncan
Copy link
Contributor Author

DBDuncan commented Jul 4, 2024

Corresponding UR PR: oneapi-src/unified-runtime#1819

@DBDuncan DBDuncan mentioned this pull request Jul 4, 2024
Merged
@DBDuncan DBDuncan marked this pull request as ready for review July 8, 2024 15:35
@DBDuncan DBDuncan requested review from a team as code owners July 8, 2024 15:35
@DBDuncan DBDuncan temporarily deployed to WindowsCILock July 9, 2024 12:06 — with GitHub Actions Inactive
@DBDuncan DBDuncan temporarily deployed to WindowsCILock July 9, 2024 13:39 — with GitHub Actions Inactive
@DBDuncan
Copy link
Contributor Author

DBDuncan commented Jul 9, 2024

Friendly ping @intel/dpcpp-nativecpu-pi-reviewers @intel/dpcpp-tools-reviewers @intel/llvm-reviewers-cuda @intel/unified-runtime-reviewers @llvm-reviewers-run @konradkusiak97 @KseniyaTikhomirova

PietroGhg
PietroGhg approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@PietroGhg PietroGhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Native CPU lgtm, thank you

konradkusiak97
konradkusiak97 reviewed Jul 9, 2024
View reviewed changes
@KseniyaTikhomirova
Copy link
Contributor

KseniyaTikhomirova commented Jul 9, 2024 •
edited
Loading

@gmlueck hi, I do not see this in approved ABI breaking change list. Could you please clarify if it is approved?

@DBDuncan DBDuncan removed request for a team July 29, 2024 13:34
@DBDuncan
Copy link
Contributor Author

Sorry. Completely messed up a merge. Had to undo the review requests it added. Should be fixed now.

@omarahmed1111
Copy link
Contributor

This will bump also UR tag to include 4 PRs:

pbalcer
pbalcer approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@pbalcer pbalcer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UR lgtm. This patch also pulls in the UR side of changes from #14513, so that PR will need updating.

@igchor
Copy link
Member

igchor commented Jul 29, 2024

@intel/llvm-gatekeepers could you please merge this? SYCL E2E failed on AWS CUDA but this seems unrelated to the PR.

@pbalcer pbalcer mentioned this pull request Jul 30, 2024
Merged
@omarahmed1111
Copy link
Contributor

UR lgtm. This patch also pulls in the UR side of changes from #14513, so that PR will need updating.

The Intel/llvm changes for this is only test fixes, so we have only included the main feature (UR PR) as part of this PR, but will keep the test fixes to be merged by the original PR as it still need reviews.

@omarahmed1111
Copy link
Contributor

@intel/llvm-gatekeepers could you please merge this? SYCL E2E failed on AWS CUDA but this seems unrelated to the PR.

@intel/llvm-gatekeepers I retriggered the runner, this should now be passing all CI, could we merge that ASAP. Thanks!

@omarahmed1111 omarahmed1111 mentioned this pull request Jul 30, 2024
Closed
@DBDuncan
Copy link
Contributor Author

@intel/llvm-gatekeepers

@sommerlukas sommerlukas merged commit 95604ae into intel:sycl Jul 30, 2024
15 checks passed
@EwanC EwanC mentioned this pull request Jul 30, 2024
Closed
nrspruit added a commit to nrspruit/llvm that referenced this pull request Jul 31, 2024
@nrspruit
[SYCL][Bindless] Fix dx12 interop samples for new external type names
ea37fed 
- fix for intel#14444

Signed-off-by: Neil R. Spruit <[email protected]>
@nrspruit nrspruit mentioned this pull request Jul 31, 2024
Merged
martygrant pushed a commit that referenced this pull request Aug 2, 2024
@nrspruit
[SYCL][Bindless] Fix dx12 interop samples for new external type names (…
ee703c8 
…#14872)

- fix for #14444

Signed-off-by: Neil R. Spruit <[email protected]>
AlexeySachkov pushed a commit to AlexeySachkov/llvm that referenced this pull request Nov 26, 2024
@nrspruit @AlexeySachkov
[SYCL][Bindless] Fix dx12 interop samples for new external type names (…
d5a60c9 
…intel#14872)

- fix for intel#14444

Signed-off-by: Neil R. Spruit <[email protected]>
AlexeySachkov pushed a commit to AlexeySachkov/llvm that referenced this pull request Nov 26, 2024
@DBDuncan @Seanst98
@cppchedy @AlexeySachkov
[SYCL][Bindless][Doc] Rename interop related structs/funcs to external (
ed10a37 
intel#14444)

Rename related interop structs/funcs with "external" keyword over
"interop" to align better with existing structs/funcs and other 3rd
party APIs.

Remove "handle" keyword from imported external memory/semaphore objects
to distinguish between 3rd party external handles and imported external
handles.

---------

Co-authored-by: Sean Stirling <[email protected]>
Co-authored-by: chedy.najjar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradkusiak97 konradkusiak97 konradkusiak97 approved these changes

@gmlueck gmlueck gmlueck approved these changes

@sarnex sarnex sarnex approved these changes

@pbalcer pbalcer pbalcer approved these changes

@isaacault isaacault isaacault approved these changes

@KseniyaTikhomirova KseniyaTikhomirova KseniyaTikhomirova approved these changes

@PietroGhg PietroGhg PietroGhg approved these changes

Assignees
No one assigned
Labels
abi-break change that's breaking abi and waiting for the next window to be able to merge sycl-bindless-images SYCL Bindless Images
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.