[UR][DeviceSantizer] Enable Symoblizer for UR santizer layer #14513

zhaomaosu · 2024-07-10T08:50:09Z

UR Part: oneapi-src/unified-runtime#1844

omarahmed1111 · 2024-07-29T14:48:38Z

Ping! @intel/dpcpp-sanitizers-review

dm-vodopyanov · 2024-07-30T07:29:27Z

sycl/plugins/unified_runtime/CMakeLists.txt

-  #     Merge pull request #1816 from nrspruit/l0_intel_driver_version
-  #     [L0] Use Intel Level Zero Driver String extension
-  set(UNIFIED_RUNTIME_TAG 529e8b9c34acd231eb5b829f6af8123e5f09c974)
+  set(UNIFIED_RUNTIME_REPO "https://github.com/zhaomaosu/unified-runtime.git")


Shouldn't be a fork, correct?

correct, this PR needs to wait until #14444 is merged, which has the required UR commits. This PR will then only have the test changes.

pbalcer · 2024-07-30T11:31:00Z

@zhaomaosu the UR side of this change was just merged. You will need to update this PR so that it includes only your test changes.

zhaomaosu · 2024-07-31T06:39:28Z

the UR side of this change was just merged. You will need to update this PR so that it includes only your test changes.

sure, updated.

zhaomaosu · 2024-08-01T10:02:21Z

Hi @intel/llvm-gatekeepers, this PR is ready to be merged. Thanks.

AlexeySachkov · 2024-08-01T12:32:53Z

It seems that this PR broke post-commit: https://github.com/intel/llvm/actions/runs/10196353773

2024-08-01T10:13:43.5810506Z FAILED: lib/libur_loader.so.0.10.0 
2024-08-01T10:13:43.5849875Z : && /opt/sycl/bin/clang++ -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wno-covered-switch-default -Wno-error -O3 -DNDEBUG  -Wl,-z,defs -Wl,-z,nodelete   -Xlinker -z -Xlinker relro -Xlinker -z -Xlinker now -Wl,--version-script=/__w/llvm/llvm/build/_deps/unified-runtime-build/source/loader/ur_loader.map -shared -Wl,-soname,libur_loader.so.0 -o lib/libur_loader.so.0.10.0 _deps/unified-runtime-build/source/loader/CMakeFiles/ur_loader.dir/ur_loader.cpp.o _deps/unified-runtime-build/source/loader/CMakeFiles/ur_loader.dir/ur_ldrddi.cpp.o _deps/unified-runtime-build/source/loader/CMakeFiles/ur_loader.dir/ur_libapi.cpp.o _deps/unified-runtime-build/source/loader/CMakeFiles/ur_loader.dir/ur_libddi.cpp.o _deps/unified-runtime-build/source/loader/CMakeFiles/ur_loader.dir/ur_lib.cpp.o _deps/unified-runtime-build/source/loader/CMakeFiles/ur_loader.dir/ur_print.cpp.o _deps/unified-runtime-build/source/loader/CMakeFiles/ur_loader.dir/layers/validation/ur_valddi.cpp.o _deps/unified-runtime-build/source/loader/CMakeFiles/ur_loader.dir/layers/validation/ur_validation_layer.cpp.o _deps/unified-runtime-build/source/loader/CMakeFiles/ur_loader.dir/layers/tracing/ur_tracing_layer.cpp.o _deps/unified-runtime-build/source/loader/CMakeFiles/ur_loader.dir/layers/tracing/ur_trcddi.cpp.o _deps/unified-runtime-build/source/loader/CMakeFiles/ur_loader.dir/__/__/__/unified-runtime-src/source/ur/ur.cpp.o _deps/unified-runtime-build/source/loader/CMakeFiles/ur_loader.dir/layers/sanitizer/asan_allocator.cpp.o _deps/unified-runtime-build/source/loader/CMakeFiles/ur_loader.dir/layers/sanitizer/asan_buffer.cpp.o _deps/unified-runtime-build/source/loader/CMakeFiles/ur_loader.dir/layers/sanitizer/asan_interceptor.cpp.o _deps/unified-runtime-build/source/loader/CMakeFiles/ur_loader.dir/layers/sanitizer/asan_quarantine.cpp.o _deps/unified-runtime-build/source/loader/CMakeFiles/ur_loader.dir/layers/sanitizer/asan_report.cpp.o _deps/unified-runtime-build/source/loader/CMakeFiles/ur_loader.dir/layers/sanitizer/asan_shadow_setup.cpp.o _deps/unified-runtime-build/source/loader/CMakeFiles/ur_loader.dir/layers/sanitizer/stacktrace.cpp.o _deps/unified-runtime-build/source/loader/CMakeFiles/ur_loader.dir/layers/sanitizer/ur_sanddi.cpp.o _deps/unified-runtime-build/source/loader/CMakeFiles/ur_loader.dir/layers/sanitizer/ur_sanitizer_layer.cpp.o _deps/unified-runtime-build/source/loader/CMakeFiles/ur_loader.dir/layers/sanitizer/ur_sanitizer_utils.cpp.o _deps/unified-runtime-build/source/loader/CMakeFiles/ur_loader.dir/layers/sanitizer/linux/backtrace.cpp.o _deps/unified-runtime-build/source/loader/CMakeFiles/ur_loader.dir/layers/sanitizer/linux/sanitizer_utils.cpp.o _deps/unified-runtime-build/source/loader/CMakeFiles/ur_loader.dir/layers/sanitizer/linux/symbolizer.cpp.o _deps/unified-runtime-build/source/loader/CMakeFiles/ur_loader.dir/layers/validation/backtrace_lin.cpp.o _deps/unified-runtime-build/source/loader/CMakeFiles/ur_loader.dir/linux/adapter_search.cpp.o  -Wl,-rpath,/__w/llvm/llvm/build/lib:  -lstdc++fs  lib/libur_common.a  lib/libxpti.a  lib/libLLVMSymbolize.so.19.0git  -lstdc++fs  -ldl  -Wl,-rpath-link,/__w/llvm/llvm/build/lib && :
2024-08-01T10:13:43.5861910Z /usr/bin/ld: _deps/unified-runtime-build/source/loader/CMakeFiles/ur_loader.dir/layers/sanitizer/linux/symbolizer.cpp.o: in function `SymbolizeCode':
2024-08-01T10:13:43.5862697Z symbolizer.cpp:(.text.SymbolizeCode+0x47): undefined reference to `vtable for llvm::raw_string_ostream'
2024-08-01T10:13:43.5863434Z /usr/bin/ld: symbolizer.cpp:(.text.SymbolizeCode+0x68): undefined reference to `llvm::raw_ostream::SetBufferAndMode(char*, unsigned long, llvm::raw_ostream::BufferKind)'
2024-08-01T10:13:43.5864207Z /usr/bin/ld: symbolizer.cpp:(.text.SymbolizeCode+0x158): undefined reference to `llvm::raw_ostream::~raw_ostream()'
2024-08-01T10:13:43.5864814Z /usr/bin/ld: symbolizer.cpp:(.text.SymbolizeCode+0x24e): undefined reference to `llvm::raw_ostream::~raw_ostream()'
2024-08-01T10:13:43.5865402Z /usr/bin/ld: symbolizer.cpp:(.text.SymbolizeCode+0x265): undefined reference to `llvm::raw_ostream::~raw_ostream()'
2024-08-01T10:13:43.5866425Z /usr/bin/ld: _deps/unified-runtime-build/source/loader/CMakeFiles/ur_loader.dir/layers/sanitizer/linux/symbolizer.cpp.o: in function `void llvm::function_ref<void (llvm::ErrorInfoBase const&, llvm::StringRef)>::callback_fn<SymbolizeCode::$_0>(long, llvm::ErrorInfoBase const&, llvm::StringRef)':
2024-08-01T10:13:43.5867717Z symbolizer.cpp:(.text._ZN4llvm12function_refIFvRKNS_13ErrorInfoBaseENS_9StringRefEEE11callback_fnIZ13SymbolizeCodeE3$_0EEvlS3_S4_+0x2b): undefined reference to `llvm::raw_ostream::write(char const*, unsigned long)'
2024-08-01T10:13:43.5868781Z /usr/bin/ld: symbolizer.cpp:(.text._ZN4llvm12function_refIFvRKNS_13ErrorInfoBaseENS_9StringRefEEE11callback_fnIZ13SymbolizeCodeE3$_0EEvlS3_S4_+0x89): undefined reference to `llvm::raw_ostream::write(unsigned char)'
2024-08-01T10:13:43.5869890Z /usr/bin/ld: _deps/unified-runtime-build/source/loader/CMakeFiles/ur_loader.dir/layers/sanitizer/linux/symbolizer.cpp.o:(.data._ZN4llvm30VerifyDisableABIBreakingChecksE+0x0): undefined reference to `llvm::DisableABIBreakingChecks'
2024-08-01T10:13:43.5870799Z clang++: error: linker command failed with exit code 1 (use -v to see invocation)

This is a self-build with shared libraries and assertions disabled

AlexeySachkov · 2024-08-01T12:34:16Z

@zhaomaosu, could you please take a look?

sarnex · 2024-08-01T14:22:49Z

If @zhaomaosu is not available, can someone from @intel/unified-runtime-reviewers take a look? Should we revert this? If I don't hear anything in about an hour I'll revert it since build is broken.

kbenzie · 2024-08-01T14:41:31Z

If @zhaomaosu is not available, can someone from @intel/unified-runtime-reviewers take a look? Should we revert this? If I don't hear anything in about an hour I'll revert it since build is broken.

I've got very little idea about the sanitizer layer change I'm afraid. It'll probably need to be reverted to unblock things. I believe @zhaomaosu timezone means they are currently asleep (I may be wrong).

sarnex · 2024-08-01T14:43:26Z

@kbenzie Appreicate the fast response, I'll revert it now.

…ntel#14513)" This reverts commit 56b1410. Build in postcommit broken https://github.com/intel/llvm/actions/runs/10196353773

…14513) (#14899) Reverts #14513 This reverts commit 56b1410. Build in postcommit broken https://github.com/intel/llvm/actions/runs/10196353773

sarnex · 2024-08-01T14:52:34Z

Reverted in 21f7f4e

@zhaomaosu Please reproduce and fix the shared library build problem, and then make a new PR with the original change plus the fix. Thanks.

kbenzie · 2024-08-01T14:59:35Z

Reverted in 21f7f4e

If this doesn't fix the build we'll need to revert the UR change as well. This could affect subsequent PR's that update the UR tag.

Edit: This doesn't actually update the tag, only enable the symbolizer. Probably okay.

sarnex · 2024-08-01T15:00:50Z

@kbenzie I'll watch it and let you know.

sarnex · 2024-08-01T15:05:56Z

@kbenzie Linux and Mac build passed, and Windows build passed even before the commit was reverted, so I think we are all set.

kbenzie · 2024-08-01T15:06:19Z

thanks @sarnex

zhaomaosu · 2024-08-02T01:25:29Z

Thank you all. Sorry for the inconvenience, I'll investigate the failures and reland the changes.

Re-land PR #14513 UR Part: oneapi-src/unified-runtime#1920

…4911) Re-land PR intel#14513 UR Part: oneapi-src/unified-runtime#1920

zhaomaosu added 3 commits July 10, 2024 16:45

[UR][DeviceSantizer] Enable Symoblizer for UR santizer layer

b87a244

Merge branch 'sycl' into implement-symbolizer

e99b795

Update tests

f0008c4

zhaomaosu temporarily deployed to WindowsCILock July 11, 2024 06:55 — with GitHub Actions Inactive

zhaomaosu temporarily deployed to WindowsCILock July 11, 2024 07:19 — with GitHub Actions Inactive

zhaomaosu mentioned this pull request Jul 12, 2024

[DeviceSanitizer] Implement symbolizer for more readable information oneapi-src/unified-runtime#1844

Merged

igchor mentioned this pull request Jul 29, 2024

Bump ur and symbolizer #14834

Closed

pbalcer mentioned this pull request Jul 29, 2024

[SYCL][Bindless][Doc] Rename interop related structs/funcs to external #14444

Merged

zhaomaosu marked this pull request as ready for review July 30, 2024 01:43

zhaomaosu requested review from a team as code owners July 30, 2024 01:43

zhaomaosu requested a review from dm-vodopyanov July 30, 2024 01:43

AllanZyne approved these changes Jul 30, 2024

View reviewed changes

dm-vodopyanov reviewed Jul 30, 2024

View reviewed changes

Merge branch 'sycl' into implement-symbolizer

0eb1ec4

zhaomaosu requested a review from a team as a code owner July 31, 2024 02:41

zhaomaosu temporarily deployed to WindowsCILock July 31, 2024 02:42 — with GitHub Actions Inactive

zhaomaosu temporarily deployed to WindowsCILock July 31, 2024 03:06 — with GitHub Actions Inactive

pbalcer approved these changes Jul 31, 2024

View reviewed changes

martygrant merged commit 56b1410 into intel:sycl Aug 1, 2024
15 checks passed

zhaomaosu deleted the implement-symbolizer branch August 1, 2024 10:15

sarnex mentioned this pull request Aug 1, 2024

Revert "[UR][DeviceSantizer] Enable Symoblizer for UR santizer layer (#14513) #14899

Merged

zhaomaosu mentioned this pull request Aug 2, 2024

[UR][DeviceSantizer] Enable Symoblizer for UR santizer layer #14911

Merged

steffenlarsen pushed a commit that referenced this pull request Aug 9, 2024

[UR][DeviceSantizer] Enable Symoblizer for UR santizer layer (#14911)

50a03c5

Re-land PR #14513 UR Part: oneapi-src/unified-runtime#1920

AlexeySachkov pushed a commit to AlexeySachkov/llvm that referenced this pull request Nov 26, 2024

[UR][DeviceSantizer] Enable Symoblizer for UR santizer layer (intel#1…

1a07d0c

…4911) Re-land PR intel#14513 UR Part: oneapi-src/unified-runtime#1920

[UR][DeviceSantizer] Enable Symoblizer for UR santizer layer #14513

[UR][DeviceSantizer] Enable Symoblizer for UR santizer layer #14513

Uh oh!

Conversation

zhaomaosu commented Jul 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

omarahmed1111 commented Jul 29, 2024

Uh oh!

dm-vodopyanov Jul 30, 2024

Choose a reason for hiding this comment

Uh oh!

pbalcer Jul 30, 2024

Choose a reason for hiding this comment

Uh oh!

pbalcer commented Jul 30, 2024

Uh oh!

zhaomaosu commented Jul 31, 2024

Uh oh!

zhaomaosu commented Aug 1, 2024

Uh oh!

Uh oh!

AlexeySachkov commented Aug 1, 2024

Uh oh!

AlexeySachkov commented Aug 1, 2024

Uh oh!

sarnex commented Aug 1, 2024

Uh oh!

kbenzie commented Aug 1, 2024

Uh oh!

sarnex commented Aug 1, 2024

Uh oh!

sarnex commented Aug 1, 2024

Uh oh!

kbenzie commented Aug 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sarnex commented Aug 1, 2024

Uh oh!

sarnex commented Aug 1, 2024

Uh oh!

kbenzie commented Aug 1, 2024

Uh oh!

zhaomaosu commented Aug 2, 2024

Uh oh!

Uh oh!

zhaomaosu commented Jul 10, 2024 •

edited

Loading

kbenzie commented Aug 1, 2024 •

edited

Loading