[SYCL] Fix bug with not found alloca command. #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good point! |
vladimirlaz
previously approved these changes
May 21, 2019
Fix bug with not found alloca in case of two accessors are created for the same memory object. The problem is that during searching for dependencies for the first accessor list of leaf command is modified so it doesn't contain commands that are considered as dependencies. As a result search for dependencies for the second accessor fails. The fix is to update list of leafs after dependencies for all accessors are found. Signed-off-by: Vlad Romanov <[email protected]>
romanovvlad
force-pushed
the
private/vromanov/FixNotFoundAlloca
branch
from
236f8c3 to
25c9f09
Compare
bader
approved these changes
May 21, 2019
vmaksimo
pushed a commit
to vmaksimo/llvm
that referenced
this pull request
Mar 3, 2021
CONFLICT (content): Merge conflict in clang/lib/Driver/Driver.cpp
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
* [ESIMD] Fix stencil tests timeouts I analyzed the history of ESIMD stencil tests in CI and found that stencil tests are sensitive to the time limit. I.e. they are not hanging but timing out before finishing the job. Since intel#148 Stencil.cpp was failing several times per day. This patch reduces back the working set for the two tests allowing them to finish before in required time limit. Also, added a test parameter to run with a bigger dimension size. * Address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug with not found alloca in case of two accessors are created for
the same memory object. The problem is that during searching for
dependencies for the first accessor list of leaf command is modified so
it doesn't contain commands that are considered as dependencies. As a
result search for dependencies for the second accessor fails.
The fix is to update list of leafs after dependencies for all accessors
are found.
Signed-off-by: Vlad Romanov [email protected]