This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[ESIMD] Fix stencil tests timeouts #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I analyzed the history of ESIMD stencil tests in CI and found that stencil tests are sensitive to the time limit. I.e. they are not hanging but timing out before finishing the job. Since intel#148 Stencil.cpp was failing several times per day. This patch reduces back the working set for the two tests allowing them to finish before in required time limit. Also, added a test parameter to run with a bigger dimension size.
kbobrovs
reviewed
Apr 22, 2021
SYCL/ESIMD/Stencil.cpp
Outdated
| @@ -79,7 +72,13 @@ bool CheckResults(float *out, float *in) { | |||
| return true; | |||
| } | |||
|
|
|||
| int main(void) { | |||
| int main(int argc, char *argv[]) { | |||
| if (argc != 2) { | |||
There was a problem hiding this comment.
I suggest to set DIM_SIZE default to 10 and override if argc == 2.
There was a problem hiding this comment.
... so that it is runnable w/o args, which most users will have no idea how to set.
vladimirlaz
suggested changes
Apr 22, 2021
| exit(1); | ||
| } | ||
| const unsigned DIM_SIZE = atoi(argv[1]); | ||
| const unsigned SQUARE_SZ = DIM_SIZE * DIM_SIZE + 16; |
There was a problem hiding this comment.
looks like code duplication. Can we move common part to header?
There was a problem hiding this comment.
Will do that as a separate patch.
kbobrovs
approved these changes
Apr 22, 2021
vladimirlaz
approved these changes
Apr 23, 2021
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Apr 12, 2022
…remove_ocl_interop_xmain [SYCL] Remove old style interop https://jira.devtools.intel.com/browse/CMPLRLLVM-30579
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
* [ESIMD] Fix stencil tests timeouts I analyzed the history of ESIMD stencil tests in CI and found that stencil tests are sensitive to the time limit. I.e. they are not hanging but timing out before finishing the job. Since intel#148 Stencil.cpp was failing several times per day. This patch reduces back the working set for the two tests allowing them to finish before in required time limit. Also, added a test parameter to run with a bigger dimension size. * Address review comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I analyzed the history of ESIMD stencil tests in CI and found that
stencil tests are sensitive to the time limit. I.e. they are not
hanging but timing out before finishing the job.
Since #148 Stencil.cpp was failing several times per day.
This patch reduces back the working set for the two tests allowing
them to finish before in required time limit. Also, added a test
parameter to run with a bigger dimension size.